Title: [230783] trunk/Source/WebKit
- Revision
- 230783
- Author
- you...@apple.com
- Date
- 2018-04-18 14:26:05 -0700 (Wed, 18 Apr 2018)
Log Message
NetworkResourceLoader should not clean itself inside didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=184754
Reviewed by Chris Dumez.
Delay the cleanup to after the didReceiveResponse call so that NetworkLoad can terminate its work.
Covered by XHR sync tests no longer crashing on GuardMalloc bots.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (230782 => 230783)
--- trunk/Source/WebKit/ChangeLog 2018-04-18 21:21:50 UTC (rev 230782)
+++ trunk/Source/WebKit/ChangeLog 2018-04-18 21:26:05 UTC (rev 230783)
@@ -1,3 +1,16 @@
+2018-04-18 Youenn Fablet <you...@apple.com>
+
+ NetworkResourceLoader should not clean itself inside didReceiveResponse
+ https://bugs.webkit.org/show_bug.cgi?id=184754
+
+ Reviewed by Chris Dumez.
+
+ Delay the cleanup to after the didReceiveResponse call so that NetworkLoad can terminate its work.
+ Covered by XHR sync tests no longer crashing on GuardMalloc bots.
+
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::didReceiveResponse):
+
2018-04-18 Jer Noble <jer.no...@apple.com>
Fix rendering of WKRemoteView layers in the simulator
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (230782 => 230783)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2018-04-18 21:21:50 UTC (rev 230782)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2018-04-18 21:26:05 UTC (rev 230783)
@@ -341,7 +341,9 @@
if (!error.isNull()) {
m_synchronousLoadData->error = WTFMove(error);
sendReplyToSynchronousRequest(*m_synchronousLoadData, nullptr);
- cleanup();
+ RunLoop::main().dispatch([protectedThis = makeRef(*this)]() {
+ protectedThis->cleanup();
+ });
return ShouldContinueDidReceiveResponse::No;
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
