Title: [230806] trunk/LayoutTests
- Revision
- 230806
- Author
- commit-qu...@webkit.org
- Date
- 2018-04-19 10:02:38 -0700 (Thu, 19 Apr 2018)
Log Message
Fix flakiness in worker-to-worker test
https://bugs.webkit.org/show_bug.cgi?id=184769
<rdar://problem/39552333>
Patch by Tadeu Zagallo <tzaga...@apple.com> on 2018-04-19
Reviewed by Alexey Proskuryakov.
* workers/worker-to-worker-expected.txt:
* workers/worker-to-worker.html:
* workers/worker-to-worker.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (230805 => 230806)
--- trunk/LayoutTests/ChangeLog 2018-04-19 16:01:09 UTC (rev 230805)
+++ trunk/LayoutTests/ChangeLog 2018-04-19 17:02:38 UTC (rev 230806)
@@ -1,3 +1,15 @@
+2018-04-19 Tadeu Zagallo <tzaga...@apple.com>
+
+ Fix flakiness in worker-to-worker test
+ https://bugs.webkit.org/show_bug.cgi?id=184769
+ <rdar://problem/39552333>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * workers/worker-to-worker-expected.txt:
+ * workers/worker-to-worker.html:
+ * workers/worker-to-worker.js:
+
2018-04-19 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rebaseline tests for iOS simulator.
Modified: trunk/LayoutTests/workers/worker-to-worker-expected.txt (230805 => 230806)
--- trunk/LayoutTests/workers/worker-to-worker-expected.txt 2018-04-19 16:01:09 UTC (rev 230805)
+++ trunk/LayoutTests/workers/worker-to-worker-expected.txt 2018-04-19 17:02:38 UTC (rev 230806)
@@ -6,6 +6,6 @@
PASS successfullyParsed is true
TEST COMPLETE
-[Worker 1] Received message: hello
-[Worker 2] Received message: hello
+[Worker] Received message: hello
+[Worker] Received message: hello
Modified: trunk/LayoutTests/workers/worker-to-worker.html (230805 => 230806)
--- trunk/LayoutTests/workers/worker-to-worker.html 2018-04-19 16:01:09 UTC (rev 230805)
+++ trunk/LayoutTests/workers/worker-to-worker.html 2018-04-19 17:02:38 UTC (rev 230806)
@@ -8,9 +8,9 @@
if (window.testRunner)
window.testRunner.waitUntilDone();
-const worker = (name, port, wait) => new Promise(resolve => {
+const worker = (port) => new Promise(resolve => {
const w = new Worker("worker-to-worker.js");
- w.postMessage({ name, wait, port }, [port]);
+ w.postMessage({ port }, [port]);
w._onmessage_ = (e) => {
debug(e.data);
resolve();
@@ -19,9 +19,8 @@
const mc = new MessageChannel();
Promise.all([
- // force one worker to wait to make order deterministic
- worker("Worker 1", mc.port1, 1),
- worker("Worker 2", mc.port2),
+ worker(mc.port1),
+ worker(mc.port2),
]).then(() => {
if (window.testRunner)
window.testRunner.notifyDone();
Modified: trunk/LayoutTests/workers/worker-to-worker.js (230805 => 230806)
--- trunk/LayoutTests/workers/worker-to-worker.js 2018-04-19 16:01:09 UTC (rev 230805)
+++ trunk/LayoutTests/workers/worker-to-worker.js 2018-04-19 17:02:38 UTC (rev 230806)
@@ -1,11 +1,6 @@
self._onmessage_ = e => {
- const {name} = e.data;
-
e.data.port._onmessage_ = e => {
- self.postMessage(`[${name}] Received message: ${e.data}`);
+ self.postMessage(`[Worker] Received message: ${e.data}`);
}
-
- const sendMsg = () => e.data.port.postMessage('hello');
- if (e.data.wait) setTimeout(sendMsg, e.data.wait);
- else sendMsg();
+ e.data.port.postMessage('hello');
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
