Title: [230889] trunk/Tools
- Revision
- 230889
- Author
- carlo...@webkit.org
- Date
- 2018-04-20 23:42:26 -0700 (Fri, 20 Apr 2018)
Log Message
[GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
https://bugs.webkit.org/show_bug.cgi?id=184815
Reviewed by Michael Catanzaro.
This is because in the test we are calling both join and detach. We should only call join.
* TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp:
(testsJSCVirtualMachine):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (230888 => 230889)
--- trunk/Tools/ChangeLog 2018-04-21 06:40:52 UTC (rev 230888)
+++ trunk/Tools/ChangeLog 2018-04-21 06:42:26 UTC (rev 230889)
@@ -1,5 +1,17 @@
2018-04-20 Carlos Garcia Campos <cgar...@igalia.com>
+ [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
+ https://bugs.webkit.org/show_bug.cgi?id=184815
+
+ Reviewed by Michael Catanzaro.
+
+ This is because in the test we are calling both join and detach. We should only call join.
+
+ * TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp:
+ (testsJSCVirtualMachine):
+
+2018-04-20 Carlos Garcia Campos <cgar...@igalia.com>
+
[GLIB] Test /jsc/prototypes crashes in debug
https://bugs.webkit.org/show_bug.cgi?id=184814
Modified: trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp (230888 => 230889)
--- trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp 2018-04-21 06:40:52 UTC (rev 230888)
+++ trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp 2018-04-21 06:42:26 UTC (rev 230889)
@@ -2510,7 +2510,6 @@
g_assert_true(jsc_value_object_is_instance_of(object.get(), jsc_class_get_name(jscClass)));
});
thread->waitForCompletion();
- thread->detach();
GRefPtr<JSCValue> object = adoptGRef(jsc_context_get_value(context.get(), "f"));
checker.watch(object.get());
@@ -2550,10 +2549,8 @@
}));
}
- for (auto& thread : threads) {
+ for (auto& thread : threads)
thread->waitForCompletion();
- thread->detach();
- }
g_assert_true(ok);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
