Title: [230896] trunk/Source/WebKit
Revision
230896
Author
commit-qu...@webkit.org
Date
2018-04-21 14:52:51 -0700 (Sat, 21 Apr 2018)

Log Message

Disable backward and forward navigation swipes while in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=184656
rdar://problem/36057535

Patch by Jeremy Jones <jere...@apple.com> on 2018-04-21
Reviewed by Tim Horton.

Disable navigation swipes while in fullscreen.

* UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::canSwipeInDirection const):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (230895 => 230896)


--- trunk/Source/WebKit/ChangeLog	2018-04-21 21:49:04 UTC (rev 230895)
+++ trunk/Source/WebKit/ChangeLog	2018-04-21 21:52:51 UTC (rev 230896)
@@ -1,3 +1,16 @@
+2018-04-21  Jeremy Jones  <jere...@apple.com>
+
+        Disable backward and forward navigation swipes while in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=184656
+        rdar://problem/36057535
+
+        Reviewed by Tim Horton.
+
+        Disable navigation swipes while in fullscreen.
+
+        * UIProcess/Cocoa/ViewGestureController.cpp:
+        (WebKit::ViewGestureController::canSwipeInDirection const):
+
 2018-04-21  Youenn Fablet  <you...@apple.com>
 
         Activate NetworkLoadChecker for media loads

Modified: trunk/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp (230895 => 230896)


--- trunk/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp	2018-04-21 21:49:04 UTC (rev 230895)
+++ trunk/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp	2018-04-21 21:52:51 UTC (rev 230896)
@@ -30,6 +30,7 @@
 #import "RemoteLayerTreeDrawingAreaProxy.h"
 #import "ViewGestureControllerMessages.h"
 #import "WebBackForwardList.h"
+#import "WebFullScreenManagerProxy.h"
 #import "WebPageProxy.h"
 #import "WebProcessProxy.h"
 #import <wtf/MathExtras.h>
@@ -115,6 +116,10 @@
     
 bool ViewGestureController::canSwipeInDirection(SwipeDirection direction) const
 {
+#if ENABLE(FULLSCREEN_API)
+    if (m_webPageProxy.fullScreenManager() && m_webPageProxy.fullScreenManager()->isFullScreen())
+        return false;
+#endif
     RefPtr<WebPageProxy> alternateBackForwardListSourcePage = m_alternateBackForwardListSourcePage.get();
     auto& backForwardList = alternateBackForwardListSourcePage ? alternateBackForwardListSourcePage->backForwardList() : m_webPageProxy.backForwardList();
     if (direction == SwipeDirection::Back)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to