Title: [101014] trunk
Revision
101014
Author
ca...@chromium.org
Date
2011-11-22 10:37:53 -0800 (Tue, 22 Nov 2011)

Log Message

Layout Test inspector/extensions/extensions-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=72966

Reviewed by Pavel Feldman.

- always bind to {add,remove}EventListener() of event target, not WebInspector.Object

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):

Modified Paths

Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101013 => 101014)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-22 18:35:41 UTC (rev 101013)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-22 18:37:53 UTC (rev 101014)
@@ -3712,7 +3712,6 @@
 BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-headers.html = CRASH PASS TIMEOUT
 BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-network-redirect.html = CRASH PASS TIMEOUT
 BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-useragent.html = CRASH PASS TIMEOUT
-BUGWK72966 WIN LINUX RELEASE : inspector/extensions/extensions-events.html = TIMEOUT
 
 BUGWK71084 WIN DEBUG SLOW : http/tests/inspector/extensions-ignore-cache.html = PASS
 

Modified: trunk/Source/WebCore/ChangeLog (101013 => 101014)


--- trunk/Source/WebCore/ChangeLog	2011-11-22 18:35:41 UTC (rev 101013)
+++ trunk/Source/WebCore/ChangeLog	2011-11-22 18:37:53 UTC (rev 101014)
@@ -1,3 +1,15 @@
+2011-11-22  Andrey Kosyakov  <ca...@chromium.org>
+
+        Layout Test inspector/extensions/extensions-events.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=72966
+
+        Reviewed by Pavel Feldman.
+
+        - always bind to {add,remove}EventListener() of event target, not WebInspector.Object
+
+        * inspector/front-end/ExtensionServer.js:
+        (WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):
+
 2011-11-22  Adam Klein  <ad...@chromium.org>
 
         Move splitView.css (added in r100991) to the correct target.

Modified: trunk/Source/WebCore/inspector/front-end/ExtensionServer.js (101013 => 101014)


--- trunk/Source/WebCore/inspector/front-end/ExtensionServer.js	2011-11-22 18:35:41 UTC (rev 101013)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionServer.js	2011-11-22 18:37:53 UTC (rev 101014)
@@ -672,8 +672,8 @@
     _registerAutosubscriptionHandler: function(eventTopic, eventTarget, frontendEventType, handler)
     {
         this._registerSubscriptionHandler(eventTopic,
-            WebInspector.Object.prototype.addEventListener.bind(eventTarget, frontendEventType, handler, this),
-            WebInspector.Object.prototype.removeEventListener.bind(eventTarget, frontendEventType, handler, this));
+            eventTarget.addEventListener.bind(eventTarget, frontendEventType, handler, this),
+            eventTarget.removeEventListener.bind(eventTarget, frontendEventType, handler, this));
     },
 
     _expandResourcePath: function(extensionPath, resourcePath)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to