Title: [231327] trunk/Source
Revision
231327
Author
commit-qu...@webkit.org
Date
2018-05-03 14:08:40 -0700 (Thu, 03 May 2018)

Log Message

[WebGL] Add runtime flag for enabling ASTC support in WebGL
https://bugs.webkit.org/show_bug.cgi?id=184840

Patch by Justin Fan <justin_...@apple.com> on 2018-05-03
Reviewed by Myles C. Maxfield.

Added runtime flag for ASTC support in WebGL, to turn on/off when extension is implemented.

Source/WebCore:

* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebGLCompressedTextureASTCSupportEnabled):
(WebCore::RuntimeEnabledFeatures::webGLCompressedTextureASTCSupportEnabled const):

Source/WebKit:

* Shared/WebPreferences.yaml:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (231326 => 231327)


--- trunk/Source/WebCore/ChangeLog	2018-05-03 20:55:44 UTC (rev 231326)
+++ trunk/Source/WebCore/ChangeLog	2018-05-03 21:08:40 UTC (rev 231327)
@@ -1,3 +1,16 @@
+2018-05-03  Justin Fan  <justin_...@apple.com>
+
+        [WebGL] Add runtime flag for enabling ASTC support in WebGL
+        https://bugs.webkit.org/show_bug.cgi?id=184840
+
+        Reviewed by Myles C. Maxfield.
+
+        Added runtime flag for ASTC support in WebGL, to turn on/off when extension is implemented.
+
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setWebGLCompressedTextureASTCSupportEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLCompressedTextureASTCSupportEnabled const):
+
 2018-05-03  Chris Nardi  <cna...@chromium.org>
 
         Remove [NoInterfaceObject] from DOMRectList

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (231326 => 231327)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-05-03 20:55:44 UTC (rev 231326)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-05-03 21:08:40 UTC (rev 231327)
@@ -252,6 +252,9 @@
 
     void setFromOriginResponseHeaderEnabled(bool isEnabled) { m_fromOriginResponseHeaderEnabled = isEnabled; }
     bool fromOriginResponseHeaderEnabled() const { return m_fromOriginResponseHeaderEnabled; }
+    
+    void setWebGLCompressedTextureASTCSupportEnabled(bool isEnabled) { m_isWebGLCompressedTextureASTCSupportEnabled = isEnabled; }
+    bool webGLCompressedTextureASTCSupportEnabled() const { return m_isWebGLCompressedTextureASTCSupportEnabled; }
 
     WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
 
@@ -388,6 +391,8 @@
     bool m_isRestrictedHTTPResponseAccess { true };
 
     bool m_fromOriginResponseHeaderEnabled { false };
+    
+    bool m_isWebGLCompressedTextureASTCSupportEnabled { false };
 
     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
 };

Modified: trunk/Source/WebKit/ChangeLog (231326 => 231327)


--- trunk/Source/WebKit/ChangeLog	2018-05-03 20:55:44 UTC (rev 231326)
+++ trunk/Source/WebKit/ChangeLog	2018-05-03 21:08:40 UTC (rev 231327)
@@ -1,3 +1,14 @@
+2018-05-03  Justin Fan  <justin_...@apple.com>
+
+        [WebGL] Add runtime flag for enabling ASTC support in WebGL
+        https://bugs.webkit.org/show_bug.cgi?id=184840
+
+        Reviewed by Myles C. Maxfield.
+
+        Added runtime flag for ASTC support in WebGL, to turn on/off when extension is implemented.
+
+        * Shared/WebPreferences.yaml:
+
 2018-05-03  Keith Rollin  <krol...@apple.com>
 
         Unreviewed build fix after <https://trac.webkit.org/changeset/231282>.

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (231326 => 231327)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-05-03 20:55:44 UTC (rev 231326)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-05-03 21:08:40 UTC (rev 231327)
@@ -1251,3 +1251,11 @@
     humanReadableDescription: "Support for the From-Origin Response Header"
     category: experimental
     webcoreBinding: RuntimeEnabledFeatures
+
+WebGLCompressedTextureASTCSupportEnabled:
+  type: bool
+  defaultValue: false
+  humanReadableName: "ASTC Texture Support"
+  humanReadableDescription: "Support for ASTC compressed texture formats in WebGL"
+  category: experimental
+  webcoreBinding: RuntimeEnabledFeatures
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to