Title: [231349] trunk
- Revision
- 231349
- Author
- carlo...@webkit.org
- Date
- 2018-05-04 03:12:03 -0700 (Fri, 04 May 2018)
Log Message
[GTK] Some event tests failing after r230817
https://bugs.webkit.org/show_bug.cgi?id=185072
Reviewed by Michael Catanzaro.
Source/WebKit:
Do not send mouse move events to the WebProcess for crossing events during testing. WTR never generates crossing
events and they can confuse tests.
Fixes: editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
fast/css/user-drag-none.html
fast/events/context-activated-by-key-event.html
fast/events/drag-selects-image.html
fast/events/dropzone-005.html
fast/events/mouse-click-events.html
fast/events/mouse-cursor-change.html
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCrossingNotifyEvent):
LayoutTests:
Remove expectations for tests that are passing now.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231348 => 231349)
--- trunk/LayoutTests/ChangeLog 2018-05-04 06:03:42 UTC (rev 231348)
+++ trunk/LayoutTests/ChangeLog 2018-05-04 10:12:03 UTC (rev 231349)
@@ -1,3 +1,14 @@
+2018-05-04 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Some event tests failing after r230817
+ https://bugs.webkit.org/show_bug.cgi?id=185072
+
+ Reviewed by Michael Catanzaro.
+
+ Remove expectations for tests that are passing now.
+
+ * platform/gtk/TestExpectations:
+
2018-05-03 Ryosuke Niwa <rn...@webkit.org>
Revert the unitended changes in r231329.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (231348 => 231349)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-05-04 06:03:42 UTC (rev 231348)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-05-04 10:12:03 UTC (rev 231349)
@@ -2349,7 +2349,6 @@
webkit.org/b/157179 editing/pasteboard/drop-file-svg.html [ Failure ]
webkit.org/b/157179 editing/pasteboard/drop-inputtext-acquires-style.html [ Failure ]
webkit.org/b/157179 editing/pasteboard/drop-link.html [ Failure ]
-webkit.org/b/157179 editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html [ Failure ]
webkit.org/b/157179 editing/pasteboard/drop-text-without-selection.html [ Failure ]
webkit.org/b/157179 editing/pasteboard/get-data-text-plain-drop.html [ Failure ]
webkit.org/b/157179 editing/pasteboard/smart-drag-drop.html [ Failure ]
@@ -2370,7 +2369,6 @@
webkit.org/b/157179 fast/events/drag-and-drop-subframe-dataTransfer.html [ Failure Timeout ]
webkit.org/b/42194 fast/events/drag-and-drop-link.html [ Failure ]
webkit.org/b/157179 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
-webkit.org/b/157179 fast/events/drag-selects-image.html [ Failure ]
webkit.org/b/157179 fast/events/draggable-div-customdata.html [ Failure ]
webkit.org/b/157179 fast/events/draggable-div-nodata.html [ Failure ]
webkit.org/b/157179 fast/events/dropzone-001.html [ Failure Timeout ]
@@ -2603,8 +2601,6 @@
# HTTP 204 (No Content) should be ignored
webkit.org/b/60206 http/tests/navigation/response204.html [ Failure ]
-webkit.org/b/61630 fast/events/dropzone-005.html [ Failure ]
-
webkit.org/b/68278 http/tests/history/back-with-fragment-change.php [ Pass Failure ]
webkit.org/b/68512 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
@@ -3079,8 +3075,6 @@
webkit.org/b/163974 fast/canvas/drawImage-with-negative-source-destination.html [ Failure ]
-webkit.org/b/163976 fast/css/user-drag-none.html [ Failure ]
-
webkit.org/b/163977 fast/css/will-change/will-change-creates-stacking-context-inline.html [ ImageOnlyFailure ]
webkit.org/b/163979 fast/css/will-change/will-change-creates-stacking-context.html [ ImageOnlyFailure ]
@@ -3367,10 +3361,6 @@
webkit.org/b/184779 transitions/clip-path-path-transitions.html [ Failure ]
webkit.org/b/184779 transitions/clip-path-transitions.html [ Failure ]
-webkit.org/b/185072 fast/events/mouse-click-events.html [ Failure ]
-webkit.org/b/185072 fast/events/context-activated-by-key-event.html [ Failure ]
-webkit.org/b/185072 fast/events/mouse-cursor-change.html [ Failure ]
-
webkit.org/b/185252 http/tests/media/hls/hls-audio-tracks.html [ Failure ]
webkit.org/b/185254 http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
Modified: trunk/Source/WebKit/ChangeLog (231348 => 231349)
--- trunk/Source/WebKit/ChangeLog 2018-05-04 06:03:42 UTC (rev 231348)
+++ trunk/Source/WebKit/ChangeLog 2018-05-04 10:12:03 UTC (rev 231349)
@@ -1,3 +1,24 @@
+2018-05-04 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Some event tests failing after r230817
+ https://bugs.webkit.org/show_bug.cgi?id=185072
+
+ Reviewed by Michael Catanzaro.
+
+ Do not send mouse move events to the WebProcess for crossing events during testing. WTR never generates crossing
+ events and they can confuse tests.
+
+ Fixes: editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
+ fast/css/user-drag-none.html
+ fast/events/context-activated-by-key-event.html
+ fast/events/drag-selects-image.html
+ fast/events/dropzone-005.html
+ fast/events/mouse-click-events.html
+ fast/events/mouse-cursor-change.html
+
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+ (webkitWebViewBaseCrossingNotifyEvent):
+
2018-05-03 Chris Dumez <cdu...@apple.com>
More aggressively terminate child processes when the connection to their parent process is severed
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (231348 => 231349)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp 2018-05-04 06:03:42 UTC (rev 231348)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp 2018-05-04 10:12:03 UTC (rev 231349)
@@ -893,6 +893,14 @@
if (priv->authenticationDialog)
return GDK_EVENT_PROPAGATE;
+#if ENABLE(DEVELOPER_MODE)
+ // Do not send mouse move events to the WebProcess for crossing events during testing.
+ // WTR never generates crossing events and they can confuse tests.
+ // https://bugs.webkit.org/show_bug.cgi?id=185072.
+ if (UNLIKELY(priv->pageProxy->process().processPool().configuration().fullySynchronousModeIsAllowedForTesting()))
+ return GDK_EVENT_PROPAGATE;
+#endif
+
// In the case of crossing events, it's very important the actual coordinates the WebProcess receives, because once the mouse leaves
// the web view, the WebProcess won't receive more events until the mouse enters again in the web view. So, if the coordinates of the leave
// event are not accurate, the WebProcess might not know the mouse left the view. This can happen because of double to integer conversion,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
