Title: [231358] trunk/Source/WebCore
- Revision
- 231358
- Author
- you...@apple.com
- Date
- 2018-05-04 10:24:08 -0700 (Fri, 04 May 2018)
Log Message
LayoutTests/fast/mediastream/change-tracks-media-stream-being-played.html is crashing after r231304
https://bugs.webkit.org/show_bug.cgi?id=185303
Reviewed by Eric Carlson.
We need to stop observing the audio track like we do for video track once we are no longer interested in it.
Covered by test no longer crashing.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (231357 => 231358)
--- trunk/Source/WebCore/ChangeLog 2018-05-04 17:21:21 UTC (rev 231357)
+++ trunk/Source/WebCore/ChangeLog 2018-05-04 17:24:08 UTC (rev 231358)
@@ -1,3 +1,16 @@
+2018-05-04 Youenn Fablet <you...@apple.com>
+
+ LayoutTests/fast/mediastream/change-tracks-media-stream-being-played.html is crashing after r231304
+ https://bugs.webkit.org/show_bug.cgi?id=185303
+
+ Reviewed by Eric Carlson.
+
+ We need to stop observing the audio track like we do for video track once we are no longer interested in it.
+ Covered by test no longer crashing.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
+
2018-05-04 Zalan Bujtas <za...@apple.com>
[LFC] Set the invalidation root as the result of style change.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (231357 => 231358)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2018-05-04 17:21:21 UTC (rev 231357)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2018-05-04 17:24:08 UTC (rev 231358)
@@ -996,6 +996,7 @@
{
switch (state) {
case TrackState::Remove:
+ track->streamTrack().removeObserver(*this);
m_player->removeAudioTrack(*track);
break;
case TrackState::Add:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
