Title: [231715] trunk/Websites/perf.webkit.org
- Revision
- 231715
- Author
- dewei_...@apple.com
- Date
- 2018-05-11 13:15:08 -0700 (Fri, 11 May 2018)
Log Message
CommitLogViewer._preceedingCommit should not always be null
https://bugs.webkit.org/show_bug.cgi?id=185540
Reviewed by Ryosuke Niwa.
Fix the bug introduced in r227746 that CommitLogViewer._preceedingCommit is always null.
* browser-tests/index.html: Fix expected measurement-set url.
* public/v3/components/commit-log-viewer.js:
(CommitLogViewer.prototype._fetchCommitLogs): CommitLogViewer._preceedingCommit should be set
when fetching for preceeding revision succeeds.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (231714 => 231715)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-05-11 19:22:34 UTC (rev 231714)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-05-11 20:15:08 UTC (rev 231715)
@@ -1,3 +1,17 @@
+2018-05-10 Dewei Zhu <dewei_...@apple.com>
+
+ CommitLogViewer._preceedingCommit should not always be null
+ https://bugs.webkit.org/show_bug.cgi?id=185540
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix the bug introduced in r227746 that CommitLogViewer._preceedingCommit is always null.
+
+ * browser-tests/index.html: Fix expected measurement-set url.
+ * public/v3/components/commit-log-viewer.js:
+ (CommitLogViewer.prototype._fetchCommitLogs): CommitLogViewer._preceedingCommit should be set
+ when fetching for preceeding revision succeeds.
+
2018-05-03 Dewei Zhu <dewei_...@apple.com>
Range bisector should check the commits for repositories without change in specified range.
Modified: trunk/Websites/perf.webkit.org/browser-tests/index.html (231714 => 231715)
--- trunk/Websites/perf.webkit.org/browser-tests/index.html 2018-05-11 19:22:34 UTC (rev 231714)
+++ trunk/Websites/perf.webkit.org/browser-tests/index.html 2018-05-11 20:15:08 UTC (rev 231715)
@@ -363,7 +363,7 @@
respondWithSampleCluster(request, options)
{
- expect(request.url).to.be('../data/measurement-set-1-1.json');
+ expect(request.url).to.be('/data/measurement-set-1-1.json');
expect(request.method).to.be('GET');
request.resolve(this.makeSampleCluster(options));
},
Modified: trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js (231714 => 231715)
--- trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js 2018-05-11 19:22:34 UTC (rev 231714)
+++ trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js 2018-05-11 20:15:08 UTC (rev 231715)
@@ -36,7 +36,6 @@
}
let promise;
- let precedingCommitPromise;
const fetchSingleCommit = !precedingRevision || precedingRevision == lastRevision;
if (fetchSingleCommit) {
promise = CommitLog.fetchForSingleRevision(repository, lastRevision).then((commits) => {
@@ -55,7 +54,7 @@
CommitLog.fetchForSingleRevision(repository, precedingRevision).then((precedingCommit) => {
if (this._fetchingPromise != promise)
return;
- this._precedingCommit = null;
+ this._precedingCommit = precedingCommit[0];
})
]);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
