Title: [231751] trunk/Source/_javascript_Core
Revision
231751
Author
commit-qu...@webkit.org
Date
2018-05-14 03:20:24 -0700 (Mon, 14 May 2018)

Log Message

[MIPS] Use btpz to compare against 0 instead of bpeq
https://bugs.webkit.org/show_bug.cgi?id=185607

Patch by Dominik Infuehr <dinfu...@igalia.com> on 2018-05-14
Reviewed by Yusuke Suzuki.

Fixes build on MIPS since MIPS doesn't have an instruction to
compare a register against an immediate. Since the immediate is just 0
in this case the simplest solution is just to use btpz instead of bpeq
to compare to 0.

* llint/LowLevelInterpreter.asm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231750 => 231751)


--- trunk/Source/_javascript_Core/ChangeLog	2018-05-14 08:32:43 UTC (rev 231750)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-05-14 10:20:24 UTC (rev 231751)
@@ -1,3 +1,17 @@
+2018-05-14  Dominik Infuehr  <dinfu...@igalia.com>
+
+        [MIPS] Use btpz to compare against 0 instead of bpeq
+        https://bugs.webkit.org/show_bug.cgi?id=185607
+
+        Reviewed by Yusuke Suzuki.
+
+        Fixes build on MIPS since MIPS doesn't have an instruction to
+        compare a register against an immediate. Since the immediate is just 0
+        in this case the simplest solution is just to use btpz instead of bpeq
+        to compare to 0.
+
+        * llint/LowLevelInterpreter.asm:
+
 2018-05-12  Filip Pizlo  <fpi...@apple.com>
 
         CachedCall::call() should be faster

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm (231750 => 231751)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2018-05-14 08:32:43 UTC (rev 231750)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2018-05-14 10:20:24 UTC (rev 231751)
@@ -1121,7 +1121,7 @@
     assert(macro (ok) bpgteq t0, 0, ok end)
     btpz t0, .argumentProfileDone
     loadp CodeBlock::m_argumentValueProfiles + VectorBufferOffset[t1], t3
-    bpeq 0, t3, .argumentProfileDone # When we can't JIT, we don't allocate any argument value profiles.
+    btpz t3, .argumentProfileDone # When we can't JIT, we don't allocate any argument value profiles.
     mulp sizeof ValueProfile, t0, t2 # Aaaaahhhh! Need strength reduction!
     lshiftp 3, t0
     addp t2, t3
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to