Title: [231775] trunk/Tools
Revision
231775
Author
commit-qu...@webkit.org
Date
2018-05-14 16:18:17 -0700 (Mon, 14 May 2018)

Log Message

test262/Runner.pm: small bugs in CLI and error codes
https://bugs.webkit.org/show_bug.cgi?id=185629

Patch by Valerie R Young <vale...@bocoup.com> on 2018-05-14
Reviewed by Michael Saboff.

Fix two commandline args with use '-f', correct
error code of failures.

* Scripts/test262/Runner.pm:
(processCLI):
(main):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (231774 => 231775)


--- trunk/Tools/ChangeLog	2018-05-14 23:16:05 UTC (rev 231774)
+++ trunk/Tools/ChangeLog	2018-05-14 23:18:17 UTC (rev 231775)
@@ -1,3 +1,17 @@
+2018-05-14  Valerie R Young  <vale...@bocoup.com>
+
+        test262/Runner.pm: small bugs in CLI and error codes
+        https://bugs.webkit.org/show_bug.cgi?id=185629
+
+        Reviewed by Michael Saboff.
+
+        Fix two commandline args with use '-f', correct
+        error code of failures.
+
+        * Scripts/test262/Runner.pm:
+        (processCLI):
+        (main):
+
 2018-05-14  Ryan Haddad  <ryanhad...@apple.com>
 
         Disable API tests that time out after pointer poisioning was disabled.

Modified: trunk/Tools/Scripts/test262/Runner.pm (231774 => 231775)


--- trunk/Tools/Scripts/test262/Runner.pm	2018-05-14 23:16:05 UTC (rev 231774)
+++ trunk/Tools/Scripts/test262/Runner.pm	2018-05-14 23:18:17 UTC (rev 231775)
@@ -130,7 +130,7 @@
         's|save' => \$saveExpectations,
         'e|expectations=s' => \$specifiedExpectationsFile,
         'x|ignore-expectations' => \$ignoreExpectations,
-        'f|failing-files' => \$failingOnly,
+        'F|failing-files' => \$failingOnly,
         'l|latest-import' => \$latestImport,
         'stats' => \$stats,
         'r|results=s' => \$specifiedResultsFile,
@@ -400,7 +400,8 @@
     my $totalTime = $endTime - $startTime;
     print "Done in $totalTime seconds!\n";
 
-    exit $newfailcount ? 1 : 0;
+    my $totalfailures = $expect ? $newfailcount : $failcount;
+    exit ($totalfailures ? 1 : 0);
 }
 
 sub loadImportFile {
@@ -932,7 +933,7 @@
 
 Ignores the test262-expectations.yaml file and outputs all failures, instead of only unexpected failures.
 
-=item B<--failing-files, -f>
+=item B<--failing-files, -F>
 
 Runs all test files that failed in a given results file (specifc with --results). This option will run the rests in both strict and non-strict modes, even if the test only fails in one of the two modes.
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to