Title: [232141] trunk/Websites/perf.webkit.org
Revision
232141
Author
dewei_...@apple.com
Date
2018-05-23 18:18:17 -0700 (Wed, 23 May 2018)

Log Message

Update ChartPane per change r231087.
https://bugs.webkit.org/show_bug.cgi?id=185570

Reviewed by Ryosuke Niwa.

On r231087 we change the return type of AnalysisTask.create, ChartPane needs to adapt
this change.

* public/v3/pages/chart-pane.js: Adapted the change that AnalysisTask.create now returns
an AnalysisTask object.
(ChartPane.prototype.async._analyzeRange):

Modified Paths

Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (232140 => 232141)


--- trunk/Websites/perf.webkit.org/ChangeLog	2018-05-24 00:53:08 UTC (rev 232140)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2018-05-24 01:18:17 UTC (rev 232141)
@@ -1,3 +1,17 @@
+2018-05-11  Dewei Zhu  <dewei_...@apple.com>
+
+        Update ChartPane per change r231087.
+        https://bugs.webkit.org/show_bug.cgi?id=185570
+
+        Reviewed by Ryosuke Niwa.
+
+        On r231087 we change the return type of AnalysisTask.create, ChartPane needs to adapt
+        this change.
+
+        * public/v3/pages/chart-pane.js: Adapted the change that AnalysisTask.create now returns
+        an AnalysisTask object.
+        (ChartPane.prototype.async._analyzeRange):
+
 2018-05-10  Dewei Zhu  <dewei_...@apple.com>
 
         CommitLogViewer._preceedingCommit should not always be null

Modified: trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js (232140 => 232141)


--- trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js	2018-05-24 00:53:08 UTC (rev 232140)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js	2018-05-24 01:18:17 UTC (rev 232141)
@@ -239,9 +239,9 @@
         const repetitionCount = this.content('confirm-repetition').value;
 
         try {
-            const data = "" (createWithTestGroup ?
+            const analysisTask = await (createWithTestGroup ?
                 AnalysisTask.create(name, startPoint, endPoint, 'Confirm', repetitionCount) : AnalysisTask.create(name, startPoint, endPoint));
-            newWindow.location.href = "" + data['taskId']);
+            newWindow.location.href = "" + analysisTask.id());
             this.fetchAnalysisTasks(true);
         } catch(error) {
             newWindow.location.href = "" {error: error});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to