Title: [232189] trunk/Source/WebInspectorUI
- Revision
- 232189
- Author
- mattba...@apple.com
- Date
- 2018-05-25 09:25:27 -0700 (Fri, 25 May 2018)
Log Message
Web Inspector: Popover dismissed while attempting to move cursor inside
https://bugs.webkit.org/show_bug.cgi?id=185741
<rdar://problem/40340938>
Reviewed by Joseph Pecoraro.
Hovering a token within the bounds of the current popover should not
show a new popover. This prevents the popover from being dismissed when
the cursor passes over a token under the transparent portion of the
popover frame.
* UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._showPopover):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (232188 => 232189)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-05-25 14:33:54 UTC (rev 232188)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-05-25 16:25:27 UTC (rev 232189)
@@ -1,3 +1,19 @@
+2018-05-25 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: Popover dismissed while attempting to move cursor inside
+ https://bugs.webkit.org/show_bug.cgi?id=185741
+ <rdar://problem/40340938>
+
+ Reviewed by Joseph Pecoraro.
+
+ Hovering a token within the bounds of the current popover should not
+ show a new popover. This prevents the popover from being dismissed when
+ the cursor passes over a token under the transparent portion of the
+ popover frame.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WI.SourceCodeTextEditor.prototype._showPopover):
+
2018-05-22 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r232052.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (232188 => 232189)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2018-05-25 14:33:54 UTC (rev 232188)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2018-05-25 16:25:27 UTC (rev 232189)
@@ -1815,6 +1815,12 @@
var rects = this.rectsForRange(candidate.hoveredTokenRange);
bounds = WI.Rect.unionOfRects(rects);
+ if (this._popover && this._popover.visible) {
+ let intersection = bounds.intersectionWithRect(this._popover.frame);
+ if (intersection.size.width && intersection.size.height)
+ return;
+ }
+
shouldHighlightRange = true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
