Title: [101175] trunk/Source/WebCore
- Revision
- 101175
- Author
- andreas.kl...@nokia.com
- Date
- 2011-11-25 08:46:42 -0800 (Fri, 25 Nov 2011)
Log Message
Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
<http://webkit.org/b/73134>
Reviewed by Antti Koivisto.
CSSMappedAttributeDeclarations always use non-strict parsing since they use
the argument-less CSSMutableStyleDeclaration constructor.
* dom/StyledElement.cpp:
(WebCore::StyledElement::createMappedDecl):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101174 => 101175)
--- trunk/Source/WebCore/ChangeLog 2011-11-25 16:19:44 UTC (rev 101174)
+++ trunk/Source/WebCore/ChangeLog 2011-11-25 16:46:42 UTC (rev 101175)
@@ -1,5 +1,23 @@
2011-11-25 Andreas Kling <kl...@webkit.org>
+ Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
+ <http://webkit.org/b/73134>
+
+ Reviewed by Antti Koivisto.
+
+ CSSMappedAttributeDeclarations always use non-strict parsing since they use
+ the argument-less CSSMutableStyleDeclaration constructor.
+
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::createMappedDecl):
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
+ (WebCore::HTMLTableElement::addSharedCellBordersDecl):
+ (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
+ (WebCore::HTMLTableElement::addSharedGroupDecls):
+
+2011-11-25 Andreas Kling <kl...@webkit.org>
+
Factor element pointer out of CSSMutableStyleDeclaration.
<http://webkit.org/b/73121>
Modified: trunk/Source/WebCore/dom/StyledElement.cpp (101174 => 101175)
--- trunk/Source/WebCore/dom/StyledElement.cpp 2011-11-25 16:19:44 UTC (rev 101174)
+++ trunk/Source/WebCore/dom/StyledElement.cpp 2011-11-25 16:46:42 UTC (rev 101175)
@@ -407,7 +407,6 @@
attr->setDecl(decl);
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
- decl->setStrictParsing(false); // Mapped attributes are just always quirky.
}
unsigned MappedAttributeHash::hash(const MappedAttributeKey& key)
Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (101174 => 101175)
--- trunk/Source/WebCore/html/HTMLTableElement.cpp 2011-11-25 16:19:44 UTC (rev 101174)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp 2011-11-25 16:46:42 UTC (rev 101175)
@@ -457,7 +457,6 @@
decl = CSSMappedAttributeDeclaration::create().leakRef(); // This single ref pins us in the table until the document dies.
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
- decl->setStrictParsing(false); // Mapped attributes are just always quirky.
int v = m_borderColorAttr ? CSSValueSolid : CSSValueOutset;
decl->setProperty(CSSPropertyBorderTopStyle, v, false);
@@ -515,7 +514,6 @@
decl = CSSMappedAttributeDeclaration::create().leakRef(); // This single ref pins us in the table until the document dies.
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
- decl->setStrictParsing(false); // Mapped attributes are just always quirky.
switch (borders) {
case SolidBordersColsOnly:
@@ -574,7 +572,6 @@
m_paddingDecl = CSSMappedAttributeDeclaration::create();
m_paddingDecl->setParentStyleSheet(document()->elementSheet());
m_paddingDecl->setElement(this);
- m_paddingDecl->setStrictParsing(false); // Mapped attributes are just always quirky.
m_paddingDecl->setProperty(CSSPropertyPaddingTop, paddingValue, false);
m_paddingDecl->setProperty(CSSPropertyPaddingRight, paddingValue, false);
@@ -601,7 +598,6 @@
decl = CSSMappedAttributeDeclaration::create().leakRef(); // This single ref pins us in the table until the document dies.
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
- decl->setStrictParsing(false); // Mapped attributes are just always quirky.
if (rows) {
decl->setProperty(CSSPropertyBorderTopWidth, CSSValueThin, false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
