Title: [101205] trunk/Source/WebCore
- Revision
- 101205
- Author
- commit-qu...@webkit.org
- Date
- 2011-11-27 12:02:25 -0800 (Sun, 27 Nov 2011)
Log Message
Add assertions that CSSMappedAttributeDeclarations aren't using strict parsing.
<http://webkit.org/b/73167>
Patch by Andreas Kling <kl...@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.
* dom/StyledElement.cpp:
(WebCore::StyledElement::createMappedDecl):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101204 => 101205)
--- trunk/Source/WebCore/ChangeLog 2011-11-27 19:48:32 UTC (rev 101204)
+++ trunk/Source/WebCore/ChangeLog 2011-11-27 20:02:25 UTC (rev 101205)
@@ -1,5 +1,20 @@
2011-11-27 Andreas Kling <kl...@webkit.org>
+ Add assertions that CSSMappedAttributeDeclarations aren't using strict parsing.
+ <http://webkit.org/b/73167>
+
+ Reviewed by Antti Koivisto.
+
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::createMappedDecl):
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
+ (WebCore::HTMLTableElement::addSharedCellBordersDecl):
+ (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
+ (WebCore::HTMLTableElement::addSharedGroupDecls):
+
+2011-11-27 Andreas Kling <kl...@webkit.org>
+
CSSStyleSheet: Removed unused create() overload.
<http://webkit.org/b/73170>
Modified: trunk/Source/WebCore/dom/StyledElement.cpp (101204 => 101205)
--- trunk/Source/WebCore/dom/StyledElement.cpp 2011-11-27 19:48:32 UTC (rev 101204)
+++ trunk/Source/WebCore/dom/StyledElement.cpp 2011-11-27 20:02:25 UTC (rev 101205)
@@ -407,6 +407,7 @@
attr->setDecl(decl);
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
+ ASSERT(!decl->useStrictParsing());
}
unsigned MappedAttributeHash::hash(const MappedAttributeKey& key)
Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (101204 => 101205)
--- trunk/Source/WebCore/html/HTMLTableElement.cpp 2011-11-27 19:48:32 UTC (rev 101204)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp 2011-11-27 20:02:25 UTC (rev 101205)
@@ -457,6 +457,7 @@
decl = CSSMappedAttributeDeclaration::create().leakRef(); // This single ref pins us in the table until the document dies.
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
+ ASSERT(!decl->useStrictParsing());
int v = m_borderColorAttr ? CSSValueSolid : CSSValueOutset;
decl->setProperty(CSSPropertyBorderTopStyle, v, false);
@@ -514,6 +515,7 @@
decl = CSSMappedAttributeDeclaration::create().leakRef(); // This single ref pins us in the table until the document dies.
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
+ ASSERT(!decl->useStrictParsing());
switch (borders) {
case SolidBordersColsOnly:
@@ -572,6 +574,7 @@
m_paddingDecl = CSSMappedAttributeDeclaration::create();
m_paddingDecl->setParentStyleSheet(document()->elementSheet());
m_paddingDecl->setElement(this);
+ ASSERT(!m_paddingDecl->useStrictParsing());
m_paddingDecl->setProperty(CSSPropertyPaddingTop, paddingValue, false);
m_paddingDecl->setProperty(CSSPropertyPaddingRight, paddingValue, false);
@@ -598,6 +601,7 @@
decl = CSSMappedAttributeDeclaration::create().leakRef(); // This single ref pins us in the table until the document dies.
decl->setParentStyleSheet(document()->elementSheet());
decl->setElement(this);
+ ASSERT(!decl->useStrictParsing());
if (rows) {
decl->setProperty(CSSPropertyBorderTopWidth, CSSValueThin, false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
