Title: [101210] trunk/Source/WebCore
Revision
101210
Author
ann...@chromium.org
Date
2011-11-27 13:13:47 -0800 (Sun, 27 Nov 2011)

Log Message

Don't allow attribute changes on <track> if feature is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=73046

Reviewed by Eric Carlson.

No new tests. This fixes a problem when --enable-video-track is not used,
but the tests use this flag.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::attributeChanged):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (101209 => 101210)


--- trunk/Source/WebCore/ChangeLog	2011-11-27 20:52:23 UTC (rev 101209)
+++ trunk/Source/WebCore/ChangeLog	2011-11-27 21:13:47 UTC (rev 101210)
@@ -1,3 +1,16 @@
+2011-11-27  Anna Cavender  <ann...@chromium.org>
+
+        Don't allow attribute changes on <track> if feature is not enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=73046
+
+        Reviewed by Eric Carlson.
+
+        No new tests. This fixes a problem when --enable-video-track is not used,
+        but the tests use this flag.
+
+        * html/HTMLTrackElement.cpp:
+        (WebCore::HTMLTrackElement::attributeChanged):
+
 2011-11-27  Andreas Kling  <kl...@webkit.org>
 
         CSSMutableStyleDeclaration: setCssText() mostly duplicates parseDeclaration().

Modified: trunk/Source/WebCore/html/HTMLTrackElement.cpp (101209 => 101210)


--- trunk/Source/WebCore/html/HTMLTrackElement.cpp	2011-11-27 20:52:23 UTC (rev 101209)
+++ trunk/Source/WebCore/html/HTMLTrackElement.cpp	2011-11-27 21:13:47 UTC (rev 101210)
@@ -91,6 +91,9 @@
 {
     HTMLElement::attributeChanged(attr, preserveDecls);
 
+    if (!RuntimeEnabledFeatures::webkitVideoTrackEnabled())
+        return;
+
     const QualifiedName& attrName = attr->name();
     if (attrName == srcAttr) {
         if (!getAttribute(srcAttr).isEmpty() && mediaElement())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to