Title: [232788] trunk/Source/_javascript_Core
Revision
232788
Author
sbar...@apple.com
Date
2018-06-12 23:24:58 -0700 (Tue, 12 Jun 2018)

Log Message

Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
https://bugs.webkit.org/show_bug.cgi?id=186071

Reviewed by Mark Lam.

* API/JSVirtualMachine.mm:
(-[JSVirtualMachine shrinkFootprint]): Deleted.
* API/JSVirtualMachinePrivate.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSVirtualMachine.mm (232787 => 232788)


--- trunk/Source/_javascript_Core/API/JSVirtualMachine.mm	2018-06-13 02:59:19 UTC (rev 232787)
+++ trunk/Source/_javascript_Core/API/JSVirtualMachine.mm	2018-06-13 06:24:58 UTC (rev 232788)
@@ -268,13 +268,6 @@
     return m_externalRememberedSet;
 }
 
-- (void)shrinkFootprint
-{
-    JSC::VM* vm = toJS(m_group);
-    JSC::JSLockHolder locker(vm);
-    vm->shrinkFootprintWhenIdle();
-}
-
 - (void)shrinkFootprintWhenIdle
 {
     JSC::VM* vm = toJS(m_group);

Modified: trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h (232787 => 232788)


--- trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h	2018-06-13 02:59:19 UTC (rev 232787)
+++ trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h	2018-06-13 06:24:58 UTC (rev 232788)
@@ -31,8 +31,6 @@
 
 @interface JSVirtualMachine(JSPrivate)
 
-- (void)shrinkFootprint; // FIXME: Remove this SPI when clients move to shrinkFootprintWhenIdle: https://bugs.webkit.org/show_bug.cgi?id=186071
-
 /*!
 @method
 @discussion Shrinks the memory footprint of the VM by deleting various internal caches,

Modified: trunk/Source/_javascript_Core/ChangeLog (232787 => 232788)


--- trunk/Source/_javascript_Core/ChangeLog	2018-06-13 02:59:19 UTC (rev 232787)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-06-13 06:24:58 UTC (rev 232788)
@@ -1,3 +1,14 @@
+2018-06-12  Saam Barati  <sbar...@apple.com>
+
+        Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
+        https://bugs.webkit.org/show_bug.cgi?id=186071
+
+        Reviewed by Mark Lam.
+
+        * API/JSVirtualMachine.mm:
+        (-[JSVirtualMachine shrinkFootprint]): Deleted.
+        * API/JSVirtualMachinePrivate.h:
+
 2018-06-11  Saam Barati  <sbar...@apple.com>
 
         Reduce graph size by replacing terminal nodes in blocks that have a ForceOSRExit with Unreachable
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to