Title: [233038] trunk/Tools
- Revision
- 233038
- Author
- commit-qu...@webkit.org
- Date
- 2018-06-21 07:00:51 -0700 (Thu, 21 Jun 2018)
Log Message
[test262-runner] Improve failures output
https://bugs.webkit.org/show_bug.cgi?id=186858
Patch by Leo Balter <leonardo.bal...@gmail.com> on 2018-06-21
Reviewed by Michael Saboff.
* Scripts/test262/Runner.pm:
(main):
(processResult):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233037 => 233038)
--- trunk/Tools/ChangeLog 2018-06-21 13:57:50 UTC (rev 233037)
+++ trunk/Tools/ChangeLog 2018-06-21 14:00:51 UTC (rev 233038)
@@ -1,3 +1,14 @@
+2018-06-21 Leo Balter <leonardo.bal...@gmail.com>
+
+ [test262-runner] Improve failures output
+ https://bugs.webkit.org/show_bug.cgi?id=186858
+
+ Reviewed by Michael Saboff.
+
+ * Scripts/test262/Runner.pm:
+ (main):
+ (processResult):
+
2018-06-21 Caitlin Potter <ca...@igalia.com>
[Tools] add a --debug option to test262/Runner.pm for buildbots
Modified: trunk/Tools/Scripts/test262/Runner.pm (233037 => 233038)
--- trunk/Tools/Scripts/test262/Runner.pm 2018-06-21 13:57:50 UTC (rev 233037)
+++ trunk/Tools/Scripts/test262/Runner.pm 2018-06-21 14:00:51 UTC (rev 233038)
@@ -459,8 +459,11 @@
if ($verbose) {
my $path = $test->{path};
my $mode = $test->{mode};
- my $err = $test->{error};
- $newfailurereport .= "FAIL $path ($mode)\n$err\n\n";
+ # Print full output from JSC
+ my $err = $test->{output};
+ $newfailurereport .= "FAIL $path ($mode)\n"
+ . "Full Output:\n"
+ . "$err\n\n";
}
}
@@ -820,18 +823,17 @@
my $failMsg = '';
$failMsg = "FAIL $file ($scenario)\n";
- my $suffixMsg = '';
+ my $featuresList = '';
- if ($verbose) {
- my $featuresList = '';
- $featuresList = "\nFeatures: " . join(', ', @{ $data->{features} }) if $data->{features};
- $suffixMsg = "$result$featuresList\n";
+ if ($verbose && $data->{features}) {
+ $featuresList = 'Features: ' . join(', ', @{ $data->{features} }) . "\n";
}
- print "$newFail$failMsg$suffixMsg" if ($printFailure || $verbose);
+ print "$newFail$failMsg$featuresList$result\n\n" if ($printFailure || $verbose);
$resultdata{result} = 'FAIL';
$resultdata{error} = $currentfailure;
+ $resultdata{output} = $result;
} elsif ($scenario ne 'skip' && !$currentfailure) {
if ($expectedfailure) {
print "NEW PASS $file ($scenario)\n";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
