Title: [233143] trunk/Source/WebCore
- Revision
- 233143
- Author
- ph...@webkit.org
- Date
- 2018-06-25 03:58:36 -0700 (Mon, 25 Jun 2018)
Log Message
[GStreamer] Remove useless workaround
https://bugs.webkit.org/show_bug.cgi?id=186921
Reviewed by Xabier Rodriguez-Calvar.
In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
the media/video-reverse-play-duration.html test passes without any
workaround needed. The other test mentioned in that bug was
removed, it seems.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233142 => 233143)
--- trunk/Source/WebCore/ChangeLog 2018-06-25 10:22:51 UTC (rev 233142)
+++ trunk/Source/WebCore/ChangeLog 2018-06-25 10:58:36 UTC (rev 233143)
@@ -1,3 +1,18 @@
+2018-06-25 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] Remove useless workaround
+ https://bugs.webkit.org/show_bug.cgi?id=186921
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
+ the media/video-reverse-play-duration.html test passes without any
+ workaround needed. The other test mentioned in that bug was
+ removed, it seems.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
+
2018-06-24 Tomas Popela <tpop...@redhat.com>
Unreviewed, address Darin's comment
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (233142 => 233143)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-06-25 10:22:51 UTC (rev 233142)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-06-25 10:58:36 UTC (rev 233143)
@@ -487,14 +487,6 @@
if (m_seeking)
return m_seekTime;
- // Workaround for
- // https://bugzilla.gnome.org/show_bug.cgi?id=639941 In GStreamer
- // 0.10.35 basesink reports wrong duration in case of EOS and
- // negative playback rate. There's no upstream accepted patch for
- // this bug yet, hence this temporary workaround.
- if (m_isEndReached && m_playbackRate < 0)
- return MediaTime::invalidTime();
-
return playbackPosition();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
