Title: [233175] trunk/Tools
- Revision
- 233175
- Author
- aakash_j...@apple.com
- Date
- 2018-06-25 14:28:25 -0700 (Mon, 25 Jun 2018)
Log Message
[ews-build] Add support for Bindings-tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187014
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-build/factories.py:
(BindingsFactory): Added RunBindingsTests build step to BindingsFactory.
* BuildSlaveSupport/ews-build/steps.py:
(RunBindingsTests): Added build-step for running Bindings tests.
* BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (233174 => 233175)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2018-06-25 21:27:11 UTC (rev 233174)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2018-06-25 21:28:25 UTC (rev 233175)
@@ -39,6 +39,12 @@
self.addStep(CheckStyle())
+class BindingsFactory(Factory):
+ def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
+ Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
+ self.addStep(RunBindingsTests())
+
+
class GTKFactory(Factory):
pass
@@ -75,9 +81,5 @@
pass
-class BindingsFactory(Factory):
- pass
-
-
class WebkitpyFactory(Factory):
pass
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (233174 => 233175)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-06-25 21:27:11 UTC (rev 233174)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-06-25 21:28:25 UTC (rev 233175)
@@ -71,3 +71,11 @@
descriptionDone = ['check-webkit-style']
flunkOnFailure = True
command = ['Tools/Scripts/check-webkit-style']
+
+
+class RunBindingsTests(shell.ShellCommand):
+ name = 'bindings-tests'
+ description = ['bindings-tests running']
+ descriptionDone = ['bindings-tests']
+ flunkOnFailure = True
+ command = ['Tools/Scripts/run-bindings-tests']
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (233174 => 233175)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-06-25 21:27:11 UTC (rev 233174)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-06-25 21:28:25 UTC (rev 233175)
@@ -228,5 +228,37 @@
return self.runStep()
+class TestRunBindingsTests(BuildStepMixinAdditions, unittest.TestCase):
+ def setUp(self):
+ self.longMessage = True
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
+
+ def test_success(self):
+ self.setupStep(RunBindingsTests())
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['Tools/Scripts/run-bindings-tests'],
+ )
+ + 0,
+ )
+ self.expectOutcome(result=SUCCESS, state_string='bindings-tests')
+ return self.runStep()
+
+ def test_failure(self):
+ self.setupStep(RunBindingsTests())
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['Tools/Scripts/run-bindings-tests'],
+ )
+ + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp')
+ + 2,
+ )
+ self.expectOutcome(result=FAILURE, state_string='bindings-tests (failure)')
+ return self.runStep()
+
+
if __name__ == '__main__':
unittest.main()
Modified: trunk/Tools/ChangeLog (233174 => 233175)
--- trunk/Tools/ChangeLog 2018-06-25 21:27:11 UTC (rev 233174)
+++ trunk/Tools/ChangeLog 2018-06-25 21:28:25 UTC (rev 233175)
@@ -1,5 +1,18 @@
2018-06-25 Aakash Jain <aakash_j...@apple.com>
+ [ews-build] Add support for Bindings-tests-EWS
+ https://bugs.webkit.org/show_bug.cgi?id=187014
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/factories.py:
+ (BindingsFactory): Added RunBindingsTests build step to BindingsFactory.
+ * BuildSlaveSupport/ews-build/steps.py:
+ (RunBindingsTests): Added build-step for running Bindings tests.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
+
+2018-06-25 Aakash Jain <aakash_j...@apple.com>
+
[ews-build] Add support for Style-EWS
https://bugs.webkit.org/show_bug.cgi?id=186955
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
