Title: [233228] trunk/Tools
Revision
233228
Author
aakash_j...@apple.com
Date
2018-06-26 17:10:23 -0700 (Tue, 26 Jun 2018)

Log Message

[build.webkit.org] Rename badly named variable kls to schedulerType
https://bugs.webkit.org/show_bug.cgi?id=186926

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
(loadBuilderConfig): Renamed kls to schedulerType.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py (233227 => 233228)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py	2018-06-26 23:22:52 UTC (rev 233227)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py	2018-06-27 00:10:23 UTC (rev 233228)
@@ -57,13 +57,13 @@
     for scheduler in config['schedulers']:
         if "change_filter" in scheduler:
             scheduler["change_filter"] = globals()[scheduler["change_filter"]]
-        kls = globals()[scheduler.pop('type')]
+        schedulerType = globals()[scheduler.pop('type')]
         # Python 2.6 can't handle unicode keys as keyword arguments:
         # http://bugs.python.org/issue2646.  Modern versions of json return
         # unicode strings from json.load, so we map all keys to str objects.
         scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items()))
 
-        c['schedulers'].append(kls(**scheduler))
+        c['schedulers'].append(schedulerType(**scheduler))
 
     forceScheduler = ForceScheduler(
         name="force",

Modified: trunk/Tools/ChangeLog (233227 => 233228)


--- trunk/Tools/ChangeLog	2018-06-26 23:22:52 UTC (rev 233227)
+++ trunk/Tools/ChangeLog	2018-06-27 00:10:23 UTC (rev 233228)
@@ -1,3 +1,13 @@
+2018-06-26  Aakash Jain  <aakash_j...@apple.com>
+
+        [build.webkit.org] Rename badly named variable kls to schedulerType
+        https://bugs.webkit.org/show_bug.cgi?id=186926
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
+        (loadBuilderConfig): Renamed kls to schedulerType.
+
 2018-06-26  Daniel Bates  <daba...@apple.com>
 
         EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to