Title: [233348] trunk/Source/WebCore
- Revision
- 233348
- Author
- za...@apple.com
- Date
- 2018-06-28 20:45:47 -0700 (Thu, 28 Jun 2018)
Log Message
[LFC] Out-of-flow positioned height does not necessarily equal to "bottom - top".
https://bugs.webkit.org/show_bug.cgi?id=187168
Reviewed by Antti Koivisto.
According to the spec "For absolutely positioned elements, the used values of the vertical dimensions must satisfy this constraint:
'top' + 'margin-top' + 'border-top-width' + 'padding-top' + 'height' + 'padding-bottom' + 'border-bottom-width' + 'margin-bottom' + 'bottom' = height of containing block"
With a non-auto "height" value, the bottom - top does not necessarily compute to the height of the element.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233347 => 233348)
--- trunk/Source/WebCore/ChangeLog 2018-06-29 01:40:26 UTC (rev 233347)
+++ trunk/Source/WebCore/ChangeLog 2018-06-29 03:45:47 UTC (rev 233348)
@@ -1,3 +1,17 @@
+2018-06-28 Zalan Bujtas <za...@apple.com>
+
+ [LFC] Out-of-flow positioned height does not necessarily equal to "bottom - top".
+ https://bugs.webkit.org/show_bug.cgi?id=187168
+
+ Reviewed by Antti Koivisto.
+
+ According to the spec "For absolutely positioned elements, the used values of the vertical dimensions must satisfy this constraint:
+ 'top' + 'margin-top' + 'border-top-width' + 'padding-top' + 'height' + 'padding-bottom' + 'border-bottom-width' + 'margin-bottom' + 'bottom' = height of containing block"
+ With a non-auto "height" value, the bottom - top does not necessarily compute to the height of the element.
+
+ * layout/FormattingContext.cpp:
+ (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
+
2018-06-28 Olivia Barnett <obarn...@apple.com>
Find in page for typographic quotes does not find low (German) quotes
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (233347 => 233348)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-06-29 01:40:26 UTC (rev 233347)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-06-29 03:45:47 UTC (rev 233348)
@@ -80,7 +80,7 @@
{
auto verticalGeometry = Geometry::outOfFlowVerticalGeometry(layoutContext, layoutBox);
displayBox.setTop(verticalGeometry.top);
- displayBox.setContentBoxHeight(verticalGeometry.bottom - verticalGeometry.top);
+ displayBox.setContentBoxHeight(verticalGeometry.heightAndMargin.height);
ASSERT(!verticalGeometry.heightAndMargin.collapsedMargin);
displayBox.setVerticalMargin(verticalGeometry.heightAndMargin.margin);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
