Title: [101274] trunk/Tools
- Revision
- 101274
- Author
- e...@webkit.org
- Date
- 2011-11-28 12:48:23 -0800 (Mon, 28 Nov 2011)
Log Message
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691
Reviewed and modified by Eric Seidel.
This is a simpler version of John's patch which I'm landing.
This just engages the hacks from the Host constructor on a global
basis.
Patch by John Yani <van...@gmail.com> on 2011-11-28
* Scripts/webkitpy/common/host.py:
(Host.__init__):
(Host._engage_awesome_locale_hacks):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (101273 => 101274)
--- trunk/Tools/ChangeLog 2011-11-28 20:21:23 UTC (rev 101273)
+++ trunk/Tools/ChangeLog 2011-11-28 20:48:23 UTC (rev 101274)
@@ -1,3 +1,18 @@
+2011-11-28 John Yani <van...@gmail.com>
+
+ new-run-webkit-tests is locale dependent
+ https://bugs.webkit.org/show_bug.cgi?id=68691
+
+ Reviewed and modified by Eric Seidel.
+
+ This is a simpler version of John's patch which I'm landing.
+ This just engages the hacks from the Host constructor on a global
+ basis.
+
+ * Scripts/webkitpy/common/host.py:
+ (Host.__init__):
+ (Host._engage_awesome_locale_hacks):
+
2011-11-28 Fady Samuel <fsam...@chromium.org>
[Chromium] Fix broken DRT build for Aura Linux
Modified: trunk/Tools/Scripts/webkitpy/common/host.py (101273 => 101274)
--- trunk/Tools/Scripts/webkitpy/common/host.py 2011-11-28 20:21:23 UTC (rev 101273)
+++ trunk/Tools/Scripts/webkitpy/common/host.py 2011-11-28 20:48:23 UTC (rev 101274)
@@ -70,6 +70,22 @@
# FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency).
self.port_factory = PortFactory(self)
+ self._engage_awesome_locale_hacks()
+
+ # We call this from the Host constructor, as it's one of the
+ # earliest calls made for all webkitpy-based programs.
+ def _engage_awesome_locale_hacks(self):
+ # To make life easier on our non-english users, we override
+ # the locale environment variables inside webkitpy.
+ # If we don't do this, programs like SVN will output localized
+ # messages and svn.py will fail to parse them.
+ # FIXME: We should do these overrides *only* for the subprocesses we know need them!
+ # This hack only works in unix environments.
+ os.environ['LANGUAGE'] = 'en'
+ os.environ['LANG'] = 'en_US.UTF-8'
+ os.environ['LC_MESSAGES'] = 'en_US.UTF-8'
+ os.environ['LC_ALL'] = ''
+
# FIXME: This is a horrible, horrible hack for ChromiumWin and should be removed.
# Maybe this belongs in SVN in some more generic "find the svn binary" codepath?
# Or possibly Executive should have a way to emulate shell path-lookups?
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
