Title: [233588] trunk
- Revision
- 233588
- Author
- grao...@webkit.org
- Date
- 2018-07-06 12:39:42 -0700 (Fri, 06 Jul 2018)
Log Message
[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-002.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186502
<rdar://problem/41000229>l
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark WPT progression.
* web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt:
Source/WebCore:
Ensure we only attempt to convert defined objects or we risk to throw errors in valid situations.
* animation/KeyframeEffectReadOnly.cpp:
(WebCore::processKeyframeLikeObject):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (233587 => 233588)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-07-06 19:33:06 UTC (rev 233587)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-07-06 19:39:42 UTC (rev 233588)
@@ -1,3 +1,15 @@
+2018-07-06 Antoine Quint <grao...@apple.com>
+
+ [Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-002.html pass reliably
+ https://bugs.webkit.org/show_bug.cgi?id=186502
+ <rdar://problem/41000229>l
+
+ Reviewed by Dean Jackson.
+
+ Mark WPT progression.
+
+ * web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt:
+
2018-07-05 Antoine Quint <grao...@apple.com>
[Web Animations] Make WPT test at interfaces/Animation/finish.html pass reliably
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt (233587 => 233588)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt 2018-07-06 19:33:06 UTC (rev 233587)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt 2018-07-06 19:39:42 UTC (rev 233588)
@@ -3,6 +3,6 @@
PASS easing values are parsed correctly when using a keyframe sequence
PASS Invalid easing values are correctly rejected when set on a property-indexed keyframe
PASS Invalid easing values are correctly rejected when using a keyframe sequence
-FAIL Errors from invalid easings on a property-indexed keyframe are thrown after reading all properties assert_equals: All properties were read before throwing the easing error expected 2 but got 1
+PASS Errors from invalid easings on a property-indexed keyframe are thrown after reading all properties
PASS Errors from invalid easings on a keyframe sequence are thrown after reading all properties
Modified: trunk/Source/WebCore/ChangeLog (233587 => 233588)
--- trunk/Source/WebCore/ChangeLog 2018-07-06 19:33:06 UTC (rev 233587)
+++ trunk/Source/WebCore/ChangeLog 2018-07-06 19:39:42 UTC (rev 233588)
@@ -1,3 +1,16 @@
+2018-07-06 Antoine Quint <grao...@apple.com>
+
+ [Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-002.html pass reliably
+ https://bugs.webkit.org/show_bug.cgi?id=186502
+ <rdar://problem/41000229>l
+
+ Reviewed by Dean Jackson.
+
+ Ensure we only attempt to convert defined objects or we risk to throw errors in valid situations.
+
+ * animation/KeyframeEffectReadOnly.cpp:
+ (WebCore::processKeyframeLikeObject):
+
2018-07-05 Antoine Quint <grao...@apple.com>
[Web Animations] Make WPT test at interfaces/Animation/finish.html pass reliably
Modified: trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp (233587 => 233588)
--- trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp 2018-07-06 19:33:06 UTC (rev 233587)
+++ trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp 2018-07-06 19:39:42 UTC (rev 233588)
@@ -270,7 +270,7 @@
// Values as the only element.
if (rawValue.isString())
propertyValues = { rawValue.toWTFString(&state) };
- else
+ else if (rawValue.isObject())
propertyValues = convert<IDLSequence<IDLDOMString>>(state, rawValue);
RETURN_IF_EXCEPTION(scope, Exception { TypeError });
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
