Title: [233708] trunk/Tools
- Revision
- 233708
- Author
- aakash_j...@apple.com
- Date
- 2018-07-10 16:42:42 -0700 (Tue, 10 Jul 2018)
Log Message
[ews-build] Add build step to UnApply patch
https://bugs.webkit.org/show_bug.cgi?id=187357
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/ews-build/steps.py:
(UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
(UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
properties will be set by build-steps for build and test.
(UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (233707 => 233708)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-07-10 23:39:50 UTC (rev 233707)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-07-10 23:42:42 UTC (rev 233708)
@@ -66,6 +66,19 @@
**kwargs)
+class UnApplyPatchIfRequired(CheckOutSource):
+ name = 'unapply-patch'
+
+ def __init__(self, **kwargs):
+ super(UnApplyPatchIfRequired, self).__init__(alwaysUseLatest=True, **kwargs)
+
+ def doStepIf(self, step):
+ return self.getProperty('patchFailedToBuild') or self.getProperty('patchFailedTests')
+
+ def hideStepIf(self, results, step):
+ return not self.doStepIf(step)
+
+
class CheckStyle(shell.ShellCommand):
name = 'check-webkit-style'
description = ['check-webkit-style running']
Modified: trunk/Tools/ChangeLog (233707 => 233708)
--- trunk/Tools/ChangeLog 2018-07-10 23:39:50 UTC (rev 233707)
+++ trunk/Tools/ChangeLog 2018-07-10 23:42:42 UTC (rev 233708)
@@ -1,3 +1,16 @@
+2018-07-10 Aakash Jain <aakash_j...@apple.com>
+
+ [ews-build] Add build step to UnApply patch
+ https://bugs.webkit.org/show_bug.cgi?id=187357
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
+ (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
+ properties will be set by build-steps for build and test.
+ (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
+
2018-07-10 Dewei Zhu <dewei_...@apple.com>
Update ARES-6.patch file accordingly for r233631.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
