Title: [234113] trunk/Source/WebCore
Revision
234113
Author
pvol...@apple.com
Date
2018-07-23 15:16:31 -0700 (Mon, 23 Jul 2018)

Log Message

WebCore::primaryScreenDisplayID() always return 0
https://bugs.webkit.org/show_bug.cgi?id=187922
<rdar://problem/42286933>

Reviewed by Geoffrey Garen.

This function should return a valid display ID.

No new tests. Testing this requires a dual monitor setup.

* platform/mac/PlatformScreenMac.mm:
(WebCore::primaryScreenDisplayID):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (234112 => 234113)


--- trunk/Source/WebCore/ChangeLog	2018-07-23 21:24:19 UTC (rev 234112)
+++ trunk/Source/WebCore/ChangeLog	2018-07-23 22:16:31 UTC (rev 234113)
@@ -1,3 +1,18 @@
+2018-07-23  Per Arne Vollan  <pvol...@apple.com>
+
+        WebCore::primaryScreenDisplayID() always return 0
+        https://bugs.webkit.org/show_bug.cgi?id=187922
+        <rdar://problem/42286933>
+
+        Reviewed by Geoffrey Garen.
+
+        This function should return a valid display ID.
+
+        No new tests. Testing this requires a dual monitor setup.
+
+        * platform/mac/PlatformScreenMac.mm:
+        (WebCore::primaryScreenDisplayID):
+
 2018-07-23  Nan Wang  <n_w...@apple.com>
 
         AX: Press tab to highlight items on a webpage is not working with voiceover enabled

Modified: trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm (234112 => 234113)


--- trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm	2018-07-23 21:24:19 UTC (rev 234112)
+++ trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm	2018-07-23 22:16:31 UTC (rev 234113)
@@ -102,11 +102,9 @@
     return screenProperties;
 }
 
-// FIXME: This function only returns 0 for now.
 static PlatformDisplayID& primaryScreenDisplayID()
 {
-    static PlatformDisplayID primaryScreenDisplayID = 0;
-    return primaryScreenDisplayID;
+    return screenProperties().primaryDisplayID;
 }
 
 static GLint rendererIDForDisplayMask(GLuint displayMask)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to