Title: [234205] releases/WebKitGTK/webkit-2.20
- Revision
- 234205
- Author
- mcatanz...@igalia.com
- Date
- 2018-07-25 10:33:32 -0700 (Wed, 25 Jul 2018)
Log Message
Merge r233080 - REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
https://bugs.webkit.org/show_bug.cgi?id=186206
Source/WebCore:
Unreviewed manual rollout of r230950
* platform/graphics/texmap/TextureMapperLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
Source/WebKit:
Unreviewed manual rollout of r230950
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::layerShouldHaveBackingStore):
LayoutTests:
Unreviewed, remove crash expectations for crashes introduced by r230950.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog 2018-07-25 17:33:32 UTC (rev 234205)
@@ -1,3 +1,12 @@
+2018-06-22 Michael Catanzaro <mcatanz...@igalia.com>
+
+ REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+ https://bugs.webkit.org/show_bug.cgi?id=186206
+
+ Unreviewed, remove crash expectations for crashes introduced by r230950.
+
+ * platform/gtk/TestExpectations:
+
2018-03-28 Daniel Bates <daba...@apple.com>
WebSocket cookie incorrectly stored
Modified: releases/WebKitGTK/webkit-2.20/LayoutTests/platform/gtk/TestExpectations (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/LayoutTests/platform/gtk/TestExpectations 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/LayoutTests/platform/gtk/TestExpectations 2018-07-25 17:33:32 UTC (rev 234205)
@@ -1312,9 +1312,28 @@
webkit.org/b/180803 http/tests/media/hls/video-cookie.html [ Crash ]
+<<<<<<< HEAD
webkit.org/b/182106 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end.html [ Crash ]
webkit.org/b/182106 media/video-multiple-concurrent-playback.html [ Crash ]
+=======
+webkit.org/b/182106 media/video-multiple-concurrent-playback.html [ Crash Pass Timeout ]
+webkit.org/b/183180 imported/blink/fast/forms/time-multiple-fields/time-multiple-fields-crash-by-focus-on-unload.html [ Crash Pass ]
+
+webkit.org/b/183215 imported/w3c/web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-cseuckr.html [ Crash Pass ]
+
+webkit.org/b/183401 fast/animation/request-animation-frame-during-modal.html [ Crash Pass ]
+
+webkit.org/b/184781 [ Release ] plugins/unavailable-plugin-indicator-obscurity.html [ Crash ]
+
+webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass ]
+
+# Crashes only when GNOME icon theme is not installed
+webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
+
+webkit.org/b/186779 http/tests/security/sandboxed-iframe-DENIED-modals.html [ Crash Pass ]
+>>>>>>> 14e2b3524ff... REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of Crashing tests
#////////////////////////////////////////////////////////////////////////////////////////
@@ -1640,7 +1659,11 @@
webkit.org/b/133865 media/W3C/video/networkState/networkState_during_progress.html [ Failure Pass ]
webkit.org/b/133866 media/media-controls-cancel-events.html [ Timeout Failure Pass ]
webkit.org/b/133867 webaudio/audioprocessingevent.html [ Failure Pass ]
+<<<<<<< HEAD
webkit.org/b/133869 media/video-seek-after-end.html [ Failure Pass ]
+=======
+webkit.org/b/133869 media/video-seek-after-end.html [ Failure ]
+>>>>>>> 14e2b3524ff... REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
# Crash is webkit.org/b/176802
webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass Crash ]
Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog 2018-07-25 17:33:32 UTC (rev 234205)
@@ -1,3 +1,14 @@
+2018-06-22 Michael Catanzaro <mcatanz...@igalia.com>
+
+ REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+ https://bugs.webkit.org/show_bug.cgi?id=186206
+
+ Unreviewed manual rollout of r230950
+
+ * platform/graphics/texmap/TextureMapperLayer.h:
+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+ (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
+
2018-03-28 Daniel Bates <daba...@apple.com>
WebSocket cookie incorrectly stored
Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2018-07-25 17:33:32 UTC (rev 234205)
@@ -117,7 +117,6 @@
void setRepaintCount(int);
void setContentsLayer(TextureMapperPlatformLayer*);
void setAnimations(const TextureMapperAnimations&);
- const TextureMapperAnimations& animations() const { return m_animations; }
void setFixedToViewport(bool);
bool fixedToViewport() const { return m_fixedToViewport; }
void setBackingStore(RefPtr<TextureMapperBackingStore>&&);
Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2018-07-25 17:33:32 UTC (rev 234205)
@@ -1108,8 +1108,7 @@
bool CoordinatedGraphicsLayer::shouldHaveBackingStore() const
{
- return drawsContent() && contentsAreVisible() && !m_size.isEmpty()
- && (!!opacity() || m_animations.hasActiveAnimationsOfType(AnimatedPropertyOpacity));
+ return drawsContent() && contentsAreVisible() && !m_size.isEmpty();
}
bool CoordinatedGraphicsLayer::selfOrAncestorHasActiveTransformAnimation() const
Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog 2018-07-25 17:33:32 UTC (rev 234205)
@@ -1,3 +1,13 @@
+2018-06-22 Michael Catanzaro <mcatanz...@igalia.com>
+
+ REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+ https://bugs.webkit.org/show_bug.cgi?id=186206
+
+ Unreviewed manual rollout of r230950
+
+ * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+ (WebKit::layerShouldHaveBackingStore):
+
2018-06-13 Adrian Perez de Castro <ape...@igalia.com>
[WPE] Trying to access the remote inspector hits an assertion in the UIProcess
Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (234204 => 234205)
--- releases/WebKitGTK/webkit-2.20/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2018-07-25 17:33:26 UTC (rev 234204)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2018-07-25 17:33:32 UTC (rev 234205)
@@ -61,8 +61,7 @@
static bool layerShouldHaveBackingStore(TextureMapperLayer* layer)
{
- return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty()
- && (!!layer->opacity() || layer->animations().hasActiveAnimationsOfType(AnimatedPropertyOpacity));
+ return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty();
}
CoordinatedGraphicsScene::CoordinatedGraphicsScene(CoordinatedGraphicsSceneClient* client)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
