[webkit-changes] [234207] trunk

[commit-queue]

Title: [234207] trunk

Revision

234207

Author

commit-qu...@webkit.org

Date

2018-07-25 10:54:17 -0700 (Wed, 25 Jul 2018)

Log Message

[INTL] Call Typed Array elements toLocaleString with locale and options
https://bugs.webkit.org/show_bug.cgi?id=185796

Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-07-25
Reviewed by Keith Miller.

JSTests:

Remove now passing TypedArray toLocaleString expectation.

* test262/expectations.yaml:

Source/_javascript_Core:

Improve ECMA 402 compliance of typed array toLocaleString, passing along
the locale and options to element toLocaleString calls.

* builtins/TypedArrayPrototype.js:
(toLocaleString):

Modified Paths

• trunk/JSTests/ChangeLog
• trunk/JSTests/test262/expectations.yaml
• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/builtins/TypedArrayPrototype.js

Diff

Modified: trunk/JSTests/ChangeLog (234206 => 234207)

--- trunk/JSTests/ChangeLog	2018-07-25 17:36:31 UTC (rev 234206)
+++ trunk/JSTests/ChangeLog	2018-07-25 17:54:17 UTC (rev 234207)
@@ -1,5 +1,16 @@
 2018-07-25  Andy VanWagoner  <andy@vanwagoner.family>
 
+        [INTL] Call Typed Array elements toLocaleString with locale and options
+        https://bugs.webkit.org/show_bug.cgi?id=185796
+
+        Reviewed by Keith Miller.
+
+        Remove now passing TypedArray toLocaleString expectation.
+
+        * test262/expectations.yaml:
+
+2018-07-25  Andy VanWagoner  <andy@vanwagoner.family>
+
         [INTL] Intl constructor lengths should be configurable
         https://bugs.webkit.org/show_bug.cgi?id=187960
 

Modified: trunk/JSTests/test262/expectations.yaml (234206 => 234207)

--- trunk/JSTests/test262/expectations.yaml	2018-07-25 17:36:31 UTC (rev 234206)
+++ trunk/JSTests/test262/expectations.yaml	2018-07-25 17:54:17 UTC (rev 234207)
@@ -1765,9 +1765,6 @@
 test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js:
   default: 'Test262Error: Should have different arrays Expected SameValue(«undefined», «undefined») to be false'
   strict mode: 'Test262Error: Should have different arrays Expected SameValue(«undefined», «undefined») to be false'
-test/intl402/TypedArray/prototype/toLocaleString/calls-toLocaleString-number-elements.js:
-  default: 'Test262Error: Expected SameValue(«0», «๐.๐๐๐») to be true (Testing with Float64Array.)'
-  strict mode: 'Test262Error: Expected SameValue(«0», «๐.๐๐๐») to be true (Testing with Float64Array.)'
 test/language/arguments-object/mapped/nonconfigurable-nonenumerable-nonwritable-descriptors-set-by-arguments.js:
   default: 'Test262Error: Expected obj[0] to have enumerable:false.'
 test/language/arguments-object/mapped/nonconfigurable-nonenumerable-nonwritable-descriptors-set-by-param.js:

Modified: trunk/Source/_javascript_Core/ChangeLog (234206 => 234207)

--- trunk/Source/_javascript_Core/ChangeLog	2018-07-25 17:36:31 UTC (rev 234206)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-07-25 17:54:17 UTC (rev 234207)
@@ -1,5 +1,18 @@
 2018-07-25  Andy VanWagoner  <andy@vanwagoner.family>
 
+        [INTL] Call Typed Array elements toLocaleString with locale and options
+        https://bugs.webkit.org/show_bug.cgi?id=185796
+
+        Reviewed by Keith Miller.
+
+        Improve ECMA 402 compliance of typed array toLocaleString, passing along
+        the locale and options to element toLocaleString calls.
+
+        * builtins/TypedArrayPrototype.js:
+        (toLocaleString):
+
+2018-07-25  Andy VanWagoner  <andy@vanwagoner.family>
+
         [INTL] Intl constructor lengths should be configurable
         https://bugs.webkit.org/show_bug.cgi?id=187960
 

Modified: trunk/Source/_javascript_Core/builtins/TypedArrayPrototype.js (234206 => 234207)

--- trunk/Source/_javascript_Core/builtins/TypedArrayPrototype.js	2018-07-25 17:36:31 UTC (rev 234206)
+++ trunk/Source/_javascript_Core/builtins/TypedArrayPrototype.js	2018-07-25 17:54:17 UTC (rev 234207)
@@ -396,7 +396,7 @@
     return result;
 }
 
-function toLocaleString()
+function toLocaleString(/* locale, options */)
 {
     "use strict";
 
@@ -405,9 +405,9 @@
     if (length == 0)
         return "";
 
-    var string = this[0].toLocaleString();
+    var string = this[0].toLocaleString(@argument(0), @argument(1));
     for (var i = 1; i < length; i++)
-        string += "," + this[i].toLocaleString();
+        string += "," + this[i].toLocaleString(@argument(0), @argument(1));
 
     return string;
 }

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes