Title: [234394] trunk/Source/WebInspectorUI
- Revision
- 234394
- Author
- nvasil...@apple.com
- Date
- 2018-07-30 16:10:56 -0700 (Mon, 30 Jul 2018)
Log Message
Web Inspector: Dark Mode: Search sidebar panel text field has a white background
https://bugs.webkit.org/show_bug.cgi?id=188128
<rdar://problem/42678270>
Reviewed by Matt Baker.
Make the search bar in Search tab match the style of the filter bar.
* UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(:matches(.search-bar, .filter-bar) > input[type="search"],):
(:matches(.search-bar, .filter-bar) > input[type="search"]::placeholder):
(:matches(.search-bar, .filter-bar) > input[type="search"]:focus):
(.filter-bar > input[type="search"]): Deleted.
(.filter-bar > input[type="search"]::placeholder): Deleted.
(.filter-bar > input[type="search"]:focus): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (234393 => 234394)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-07-30 23:07:17 UTC (rev 234393)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-07-30 23:10:56 UTC (rev 234394)
@@ -1,3 +1,22 @@
+2018-07-30 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Dark Mode: Search sidebar panel text field has a white background
+ https://bugs.webkit.org/show_bug.cgi?id=188128
+ <rdar://problem/42678270>
+
+ Reviewed by Matt Baker.
+
+ Make the search bar in Search tab match the style of the filter bar.
+
+ * UserInterface/Views/DarkMode.css:
+ (@media (prefers-dark-interface)):
+ (:matches(.search-bar, .filter-bar) > input[type="search"],):
+ (:matches(.search-bar, .filter-bar) > input[type="search"]::placeholder):
+ (:matches(.search-bar, .filter-bar) > input[type="search"]:focus):
+ (.filter-bar > input[type="search"]): Deleted.
+ (.filter-bar > input[type="search"]::placeholder): Deleted.
+ (.filter-bar > input[type="search"]:focus): Deleted.
+
2018-07-26 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r234281.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css (234393 => 234394)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css 2018-07-30 23:07:17 UTC (rev 234393)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css 2018-07-30 23:10:56 UTC (rev 234394)
@@ -924,17 +924,18 @@
}
- /* FilterBar.css */
- .filter-bar > input[type="search"] {
+ /* FilterBar.css, SearchBar.css */
+ :matches(.search-bar, .filter-bar) > input[type="search"],
+ .search-bar > input[type="search"]:not(:placeholder-shown) {
border-color: var(--background-color-selected);
background-color: var(--background-color-alternate);
}
- .filter-bar > input[type="search"]::placeholder {
+ :matches(.search-bar, .filter-bar) > input[type="search"]::placeholder {
color: var(--text-color-secondary);
}
- .filter-bar > input[type="search"]:focus {
+ :matches(.search-bar, .filter-bar) > input[type="search"]:focus {
background-color: hsla(0, 0%, var(--foreground-lightness), 0.2);
color: var(--text-color-active);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
