Title: [234432] trunk/Source/WebCore
- Revision
- 234432
- Author
- timo...@apple.com
- Date
- 2018-07-31 11:23:36 -0700 (Tue, 31 Jul 2018)
Log Message
Don't call RenderTheme::platformColorsDidChange() during printing.
https://bugs.webkit.org/show_bug.cgi?id=188181
rdar://problem/42360070
Reviewed by Tim Horton.
* inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setEmulatedMedia): Call m_page.updateStyleAfterChangeInEnvironment()
instead of going to styleStope() and remove call to RenderTheme::platformColorsDidChange().
* page/FrameView.cpp:
(WebCore::FrameView::adjustMediaTypeForPrinting): Remove call RenderTheme::platformColorsDidChange().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234431 => 234432)
--- trunk/Source/WebCore/ChangeLog 2018-07-31 18:23:01 UTC (rev 234431)
+++ trunk/Source/WebCore/ChangeLog 2018-07-31 18:23:36 UTC (rev 234432)
@@ -1,3 +1,17 @@
+2018-07-31 Timothy Hatcher <timo...@apple.com>
+
+ Don't call RenderTheme::platformColorsDidChange() during printing.
+ https://bugs.webkit.org/show_bug.cgi?id=188181
+ rdar://problem/42360070
+
+ Reviewed by Tim Horton.
+
+ * inspector/agents/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::setEmulatedMedia): Call m_page.updateStyleAfterChangeInEnvironment()
+ instead of going to styleStope() and remove call to RenderTheme::platformColorsDidChange().
+ * page/FrameView.cpp:
+ (WebCore::FrameView::adjustMediaTypeForPrinting): Remove call RenderTheme::platformColorsDidChange().
+
2018-07-31 Yusuke Suzuki <utatane....@gmail.com>
Use static const global variable for TransformationMatrix instead of NeverDestroyed
Modified: trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp (234431 => 234432)
--- trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp 2018-07-31 18:23:01 UTC (rev 234431)
+++ trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp 2018-07-31 18:23:36 UTC (rev 234432)
@@ -802,12 +802,10 @@
m_emulatedMedia = media;
- RenderTheme::singleton().platformColorsDidChange();
+ m_page.updateStyleAfterChangeInEnvironment();
- if (auto document = m_page.mainFrame().document()) {
- document->styleScope().didChangeStyleSheetEnvironment();
+ if (auto* document = m_page.mainFrame().document())
document->updateLayout();
- }
}
void InspectorPageAgent::applyEmulatedMedia(String& media)
Modified: trunk/Source/WebCore/page/FrameView.cpp (234431 => 234432)
--- trunk/Source/WebCore/page/FrameView.cpp 2018-07-31 18:23:01 UTC (rev 234431)
+++ trunk/Source/WebCore/page/FrameView.cpp 2018-07-31 18:23:36 UTC (rev 234432)
@@ -1388,8 +1388,6 @@
setMediaType(m_mediaTypeWhenNotPrinting);
m_mediaTypeWhenNotPrinting = String();
}
-
- RenderTheme::singleton().platformColorsDidChange();
}
bool FrameView::useSlowRepaints(bool considerOverlap) const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
