Title: [234633] trunk/Source/WebCore
Revision
234633
Author
simon.fra...@apple.com
Date
2018-08-06 15:35:50 -0700 (Mon, 06 Aug 2018)

Log Message

Clean up initialization of some RenderLayer members
https://bugs.webkit.org/show_bug.cgi?id=188330

Reviewed by Dean Jackson.

Use initializers for the pointers. No need to initialize LayoutUnits, which initialize to zero.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (234632 => 234633)


--- trunk/Source/WebCore/ChangeLog	2018-08-06 22:34:50 UTC (rev 234632)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 22:35:50 UTC (rev 234633)
@@ -1,3 +1,16 @@
+2018-08-06  Simon Fraser  <simon.fra...@apple.com>
+
+        Clean up initialization of some RenderLayer members
+        https://bugs.webkit.org/show_bug.cgi?id=188330
+
+        Reviewed by Dean Jackson.
+
+        Use initializers for the pointers. No need to initialize LayoutUnits, which initialize to zero.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::RenderLayer):
+        * rendering/RenderLayer.h:
+
 2018-08-06  Said Abou-Hallawa  <sabouhall...@apple.com>
 
         Remove the SVG elements' attributes macros

Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (234632 => 234633)


--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2018-08-06 22:34:50 UTC (rev 234632)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2018-08-06 22:35:50 UTC (rev 234633)
@@ -319,13 +319,6 @@
     , m_hasNotIsolatedBlendingDescendantsStatusDirty(false)
 #endif
     , m_renderer(rendererLayerModelObject)
-    , m_parent(nullptr)
-    , m_previous(nullptr)
-    , m_next(nullptr)
-    , m_first(nullptr)
-    , m_last(nullptr)
-    , m_staticInlinePosition(0)
-    , m_staticBlockPosition(0)
 {
     m_isNormalFlowOnly = shouldBeNormalFlowOnly();
     m_isSelfPaintingLayer = shouldBeSelfPaintingLayer();

Modified: trunk/Source/WebCore/rendering/RenderLayer.h (234632 => 234633)


--- trunk/Source/WebCore/rendering/RenderLayer.h	2018-08-06 22:34:50 UTC (rev 234632)
+++ trunk/Source/WebCore/rendering/RenderLayer.h	2018-08-06 22:35:50 UTC (rev 234633)
@@ -1109,11 +1109,11 @@
 
     RenderLayerModelObject& m_renderer;
 
-    RenderLayer* m_parent;
-    RenderLayer* m_previous;
-    RenderLayer* m_next;
-    RenderLayer* m_first;
-    RenderLayer* m_last;
+    RenderLayer* m_parent { nullptr };
+    RenderLayer* m_previous { nullptr };
+    RenderLayer* m_next { nullptr };
+    RenderLayer* m_first { nullptr };
+    RenderLayer* m_last { nullptr };
 
     // Our current relative position offset.
     LayoutSize m_offsetForInFlowPosition;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to