Diff
Modified: trunk/LayoutTests/ChangeLog (234669 => 234670)
--- trunk/LayoutTests/ChangeLog 2018-08-07 21:13:07 UTC (rev 234669)
+++ trunk/LayoutTests/ChangeLog 2018-08-07 21:28:47 UTC (rev 234670)
@@ -1,3 +1,18 @@
+2018-08-07 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r234669.
+ https://bugs.webkit.org/show_bug.cgi?id=188390
+
+ Didn't commit the actual change (Requested by rniwa on
+ #webkit).
+
+ Reverted changeset:
+
+ "document.open and document.write must throw while the HTML
+ parser is synchronously constructing a custom element"
+ https://bugs.webkit.org/show_bug.cgi?id=187319
+ https://trac.webkit.org/changeset/234669
+
2018-08-07 Ryosuke Niwa <rn...@webkit.org>
document.open and document.write must throw while the HTML parser is synchronously constructing a custom element
Deleted: trunk/LayoutTests/fast/custom-elements/resources/navigation-destination.html (234669 => 234670)
--- trunk/LayoutTests/fast/custom-elements/resources/navigation-destination.html 2018-08-07 21:13:07 UTC (rev 234669)
+++ trunk/LayoutTests/fast/custom-elements/resources/navigation-destination.html 2018-08-07 21:28:47 UTC (rev 234670)
@@ -1,9 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>Navigated!</p>
-<script>
-parent.postMessage('didNavigate', '*');
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt (234669 => 234670)
--- trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt 2018-08-07 21:13:07 UTC (rev 234669)
+++ trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt 2018-08-07 21:28:47 UTC (rev 234670)
@@ -1,13 +0,0 @@
-
-PASS document.open() must throw an InvalidStateError when synchronously constructing a custom element
-PASS document.open("text/html") must throw an InvalidStateError when synchronously constructing a custom element
-PASS document.open(URL) must NOT throw an InvalidStateError when synchronously constructing a custom element
-PASS document.close() must throw an InvalidStateError when synchronously constructing a custom element
-PASS document.write must throw an InvalidStateError when synchronously constructing a custom element
-PASS document.writeln must throw an InvalidStateError when synchronously constructing a custom element
-PASS document.open() of another document must not throw an InvalidStateError when synchronously constructing a custom element
-PASS document.open("text/html") of another document must not throw an InvalidStateError when synchronously constructing a custom element
-PASS document.close() of another document must not throw an InvalidStateError when synchronously constructing a custom element
-PASS document.write of another document must not throw an InvalidStateError when synchronously constructing a custom element
-PASS document.writeln of another document must not throw an InvalidStateError when synchronously constructing a custom element
-
Deleted: trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html (234669 => 234670)
--- trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html 2018-08-07 21:13:07 UTC (rev 234669)
+++ trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html 2018-08-07 21:28:47 UTC (rev 234670)
@@ -1,117 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<title>Custom Elements: create an element for a token must increment and decrement document's throw-on-dynamic-markup-insertion counter</title>
-<meta name="author" title="Ryosuke Niwa" href=""
-<meta name="assert" content="Invoking document.open, document.write, document.writeln, and document.write must throw an exception when the HTML parser is creating a custom element for a token">
-<meta name="help" content="https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token">
-<meta name="help" content="https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#throw-on-dynamic-markup-insertion-counter">
-<script src=""
-<script src=""
-<script src=""
-</head>
-<body>
-<div id="log"></div>
-<script>
-
-async function construct_custom_element_in_parser(test, call_function)
-{
- const window = await create_window_in_test(test);
- const document = window.document;
-
- document.open();
-
- let executed = false;
- let exception = null;
- class CustomElement extends window.HTMLElement {
- constructor() {
- super();
- try {
- call_function(document, window);
- } catch (error) {
- exception = error;
- }
- executed = true;
- }
- }
- window.customElements.define('some-element', CustomElement);
-
- document.write('<!DOCTYPE html><html><body><some-element></some-element></body></html>');
- document.close();
-
- assert_true(executed, 'Must synchronously instantiate a custom element');
- return {window, document, exception};
-}
-
-promise_test(async function () {
- const result = await construct_custom_element_in_parser(this, (document) => document.open());
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
-}, 'document.open() must throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const result = await construct_custom_element_in_parser(this, (document) => document.open('text/html'));
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
-}, 'document.open("text/html") must throw an InvalidStateError when synchronously constructing a custom element');
-
-// https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dom-document-open-window
-promise_test(async function () {
- let load_promise = new Promise((resolve) => window._onmessage_ = (event) => resolve(event.data));
- const result = await construct_custom_element_in_parser(this, (document, window) => document.open('resources/navigation-destination.html', '_self', ''));
- assert_equals(result.exception, null);
- assert_equals(await load_promise, 'didNavigate');
-}, 'document.open(URL) must NOT throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const result = await construct_custom_element_in_parser(this, (document) => document.close());
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
-}, 'document.close() must throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const result = await construct_custom_element_in_parser(this, (document) => document.write('<b>some text</b>'));
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
- assert_equals(result.document.querySelector('b'), null, 'Must not insert new content');
- assert_false(result.document.documentElement.innerHTML.includes('some text'), 'Must not insert new content');
-}, 'document.write must throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const result = await construct_custom_element_in_parser(this, (document) => document.writeln('<b>some text</b>'));
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
- assert_equals(result.document.querySelector('b'), null, 'Must not insert new content');
- assert_false(result.document.documentElement.innerHTML.includes('some text'), 'Must not insert new content');
-}, 'document.writeln must throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await construct_custom_element_in_parser(this, (document) => another_window.document.open());
- assert_equals(result.exception, null);
-}, 'document.open() of another document must not throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await construct_custom_element_in_parser(this, (document) => another_window.document.open('text/html'));
- assert_equals(result.exception, null);
-}, 'document.open("text/html") of another document must not throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await construct_custom_element_in_parser(this, (document) => another_window.document.close());
- assert_equals(result.exception, null);
-}, 'document.close() of another document must not throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await construct_custom_element_in_parser(this, (document) => another_window.document.write('<b>some text</b>'));
- assert_equals(result.exception, null);
- assert_equals(another_window.document.querySelector('b').outerHTML, '<b>some text</b>');
-}, 'document.write of another document must not throw an InvalidStateError when synchronously constructing a custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await construct_custom_element_in_parser(this, (document) => another_window.document.writeln('<b>some text</b>'));
- assert_equals(result.exception, null);
- assert_equals(another_window.document.querySelector('b').outerHTML, '<b>some text</b>');
-}, 'document.writeln of another document must not throw an InvalidStateError when synchronously constructing a custom element');
-
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt (234669 => 234670)
--- trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt 2018-08-07 21:13:07 UTC (rev 234669)
+++ trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt 2018-08-07 21:28:47 UTC (rev 234670)
@@ -1,13 +0,0 @@
-
-PASS document.open() must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.open("text/html") must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.open(URL) must NOT throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.close() must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.write must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.writeln must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.open() of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.open("text/html") of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.close() of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.write of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-PASS document.writeln of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element
-
Deleted: trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html (234669 => 234670)
--- trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html 2018-08-07 21:13:07 UTC (rev 234669)
+++ trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html 2018-08-07 21:28:47 UTC (rev 234670)
@@ -1,117 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<title>Custom Elements: create an element for a token must increment and decrement document's throw-on-dynamic-markup-insertion counter</title>
-<meta name="author" title="Ryosuke Niwa" href=""
-<meta name="assert" content="Invoking document.open, document.write, document.writeln, and document.write must throw an exception when the HTML parser is creating a custom element for a token">
-<meta name="help" content="https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token">
-<meta name="help" content="https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#throw-on-dynamic-markup-insertion-counter">
-<script src=""
-<script src=""
-<script src=""
-</head>
-<body>
-<div id="log"></div>
-<script>
-
-async function custom_element_reactions_in_parser(test, call_function)
-{
- const window = await create_window_in_test(test);
- const document = window.document;
-
- document.open();
-
- let executed = false;
- let exception = null;
- class CustomElement extends window.HTMLElement {
- attributeChangedCallback(name, oldValue, newValue) {
- try {
- call_function(document, window);
- } catch (error) {
- exception = error;
- }
- executed = true;
- }
- }
- CustomElement.observedAttributes = ['title'];
- window.customElements.define('some-element', CustomElement);
-
- document.write('<!DOCTYPE html><html><body><some-element title="some title"></some-element></body></html>');
- document.close();
-
- assert_true(executed, 'Must immediately process custom element reactions for setting attributes');
- return {frameElement, window, document, exception};
-}
-
-promise_test(async function () {
- const result = await custom_element_reactions_in_parser(this, (document) => document.open());
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
-}, 'document.open() must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const result = await custom_element_reactions_in_parser(this, (document) => document.open('text/html'));
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
-}, 'document.open("text/html") must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-// https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dom-document-open-window
-promise_test(async function () {
- let load_promise = new Promise((resolve) => window._onmessage_ = (event) => resolve(event.data));
- const result = await custom_element_reactions_in_parser(this, (document, window) => document.open('resources/navigation-destination.html', '_self', ''));
- assert_equals(result.exception, null);
- assert_equals(await load_promise, 'didNavigate');
-}, 'document.open(URL) must NOT throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const result = await custom_element_reactions_in_parser(this, (document) => document.close());
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
-}, 'document.close() must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const result = await custom_element_reactions_in_parser(this, (document) => document.write('<b>some text</b>'));
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
- assert_equals(result.document.querySelector('b'), null, 'Must not insert new content');
- assert_false(result.document.documentElement.innerHTML.includes('some text'), 'Must not insert new content');
-}, 'document.write must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const result = await custom_element_reactions_in_parser(this, (document) => document.writeln('<b>some text</b>'));
- assert_throws({name: 'InvalidStateError'}, () => { throw result.exception; }, 'Must throw an InvalidStateError');
- assert_equals(result.document.querySelector('b'), null, 'Must not insert new content');
- assert_false(result.document.documentElement.innerHTML.includes('some text'), 'Must not insert new content');
-}, 'document.writeln must throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await custom_element_reactions_in_parser(this, (document) => another_window.document.open());
- assert_equals(result.exception, null);
-}, 'document.open() of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await custom_element_reactions_in_parser(this, (document) => another_window.document.open('text/html'));
- assert_equals(result.exception, null);
-}, 'document.open("text/html") of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await custom_element_reactions_in_parser(this, (document) => another_window.document.close());
- assert_equals(result.exception, null);
-}, 'document.close() of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await custom_element_reactions_in_parser(this, (document) => another_window.document.write('<b>some text</b>'));
- assert_equals(result.exception, null);
- assert_equals(another_window.document.querySelector('b').outerHTML, '<b>some text</b>');
-}, 'document.write of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-promise_test(async function () {
- const another_window = await create_window_in_test(this);
- const result = await custom_element_reactions_in_parser(this, (document) => another_window.document.writeln('<b>some text</b>'));
- assert_equals(result.exception, null);
- assert_equals(another_window.document.querySelector('b').outerHTML, '<b>some text</b>');
-}, 'document.writeln of another document must not throw an InvalidStateError when processing custom element reactions for a synchronous constructed custom element');
-
-</script>
-</body>
-</html>
