Title: [101463] trunk/Tools
Revision
101463
Author
fsam...@chromium.org
Date
2011-11-30 01:27:08 -0800 (Wed, 30 Nov 2011)

Log Message

[Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=73328

Reviewed by Kent Tamura.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::enableFixedLayoutMode):
(LayoutTestController::setFixedLayoutSize):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (101462 => 101463)


--- trunk/Tools/ChangeLog	2011-11-30 09:22:10 UTC (rev 101462)
+++ trunk/Tools/ChangeLog	2011-11-30 09:27:08 UTC (rev 101463)
@@ -1,3 +1,14 @@
+2011-11-30  Fady Samuel  <fsam...@chromium.org>
+
+        [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
+        https://bugs.webkit.org/show_bug.cgi?id=73328
+
+        Reviewed by Kent Tamura.
+
+        * DumpRenderTree/chromium/LayoutTestController.cpp:
+        (LayoutTestController::enableFixedLayoutMode):
+        (LayoutTestController::setFixedLayoutSize):
+
 2011-11-29  Hayato Ito  <hay...@chromium.org>
 
         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.

Modified: trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp (101462 => 101463)


--- trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp	2011-11-30 09:22:10 UTC (rev 101462)
+++ trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp	2011-11-30 09:27:08 UTC (rev 101463)
@@ -2022,21 +2022,21 @@
 
 void LayoutTestController::enableFixedLayoutMode(const CppArgumentList& arguments, CppVariant* result)
 {
+    result->setNull();
     if (arguments.size() <  1 || !arguments[0].isBool())
         return;
     bool enableFixedLayout = arguments[0].toBoolean();
     m_shell->webView()->enableFixedLayoutMode(enableFixedLayout);
-    result->setNull();
 }
 
 void LayoutTestController::setFixedLayoutSize(const CppArgumentList& arguments, CppVariant* result)
 {
+    result->setNull();
     if (arguments.size() <  2 || !arguments[0].isNumber() || !arguments[1].isNumber())
         return;
     int width = arguments[0].toInt32();
     int height = arguments[1].toInt32();
     m_shell->webView()->setFixedLayoutSize(WebSize(width, height));
-    result->setNull();
 }
 
 void LayoutTestController::setPluginsEnabled(const CppArgumentList& arguments, CppVariant* result)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to