Title: [234967] trunk/Source/WebCore
- Revision
- 234967
- Author
- [email protected]
- Date
- 2018-08-16 16:05:54 -0700 (Thu, 16 Aug 2018)
Log Message
Remove unused allowScriptsToCloseWindows setting
https://bugs.webkit.org/show_bug.cgi?id=188602
Reviewed by Simon Fraser.
No change in behaviour. It was always false.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
* page/Settings.yaml:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234966 => 234967)
--- trunk/Source/WebCore/ChangeLog 2018-08-16 23:03:09 UTC (rev 234966)
+++ trunk/Source/WebCore/ChangeLog 2018-08-16 23:05:54 UTC (rev 234967)
@@ -1,3 +1,16 @@
+2018-08-16 Alex Christensen <[email protected]>
+
+ Remove unused allowScriptsToCloseWindows setting
+ https://bugs.webkit.org/show_bug.cgi?id=188602
+
+ Reviewed by Simon Fraser.
+
+ No change in behaviour. It was always false.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::close):
+ * page/Settings.yaml:
+
2018-08-16 Ryosuke Niwa <[email protected]>
Custom element constructor doesn't use HTMLElement in new.target's realm
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (234966 => 234967)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2018-08-16 23:03:09 UTC (rev 234966)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2018-08-16 23:05:54 UTC (rev 234967)
@@ -1086,9 +1086,7 @@
if (!m_frame->isMainFrame())
return;
- bool allowScriptsToCloseWindows = m_frame->settings().allowScriptsToCloseWindows();
-
- if (!(page->openedByDOM() || page->backForward().count() <= 1 || allowScriptsToCloseWindows)) {
+ if (!(page->openedByDOM() || page->backForward().count() <= 1)) {
console()->addMessage(MessageSource::JS, MessageLevel::Warning, "Can't close the window since it was not opened by _javascript_"_s);
return;
}
Modified: trunk/Source/WebCore/page/Settings.yaml (234966 => 234967)
--- trunk/Source/WebCore/page/Settings.yaml 2018-08-16 23:03:09 UTC (rev 234966)
+++ trunk/Source/WebCore/page/Settings.yaml 2018-08-16 23:05:54 UTC (rev 234967)
@@ -192,8 +192,6 @@
initial: true
usesEncodingDetector:
initial: false
-allowScriptsToCloseWindows:
- initial: false
canvasUsesAcceleratedDrawing:
initial: false
acceleratedDrawingEnabled:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
