Title: [235208] trunk/Source/WebKit
- Revision
- 235208
- Author
- timothy_hor...@apple.com
- Date
- 2018-08-22 15:51:22 -0700 (Wed, 22 Aug 2018)
Log Message
De-unify WebPage
https://bugs.webkit.org/show_bug.cgi?id=188865
Reviewed by Wenson Hsieh.
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:
WebPage being unified is causing mysterious build issues inside Carbon headers
on High Sierra only. Also, WebPage by itself takes longer to build than
most full unified source files, so it might not make sense to unify it
with others (to maximize parallelism).
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235207 => 235208)
--- trunk/Source/WebKit/ChangeLog 2018-08-22 22:49:42 UTC (rev 235207)
+++ trunk/Source/WebKit/ChangeLog 2018-08-22 22:51:22 UTC (rev 235208)
@@ -1,3 +1,17 @@
+2018-08-22 Tim Horton <timothy_hor...@apple.com>
+
+ De-unify WebPage
+ https://bugs.webkit.org/show_bug.cgi?id=188865
+
+ Reviewed by Wenson Hsieh.
+
+ * Sources.txt:
+ * WebKit.xcodeproj/project.pbxproj:
+ WebPage being unified is causing mysterious build issues inside Carbon headers
+ on High Sierra only. Also, WebPage by itself takes longer to build than
+ most full unified source files, so it might not make sense to unify it
+ with others (to maximize parallelism).
+
2018-08-22 David Fenton <david_fen...@apple.com>
Unreviewed, rolling out r235204.
Modified: trunk/Source/WebKit/Sources.txt (235207 => 235208)
--- trunk/Source/WebKit/Sources.txt 2018-08-22 22:49:42 UTC (rev 235207)
+++ trunk/Source/WebKit/Sources.txt 2018-08-22 22:51:22 UTC (rev 235208)
@@ -539,7 +539,7 @@
WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp
WebProcess/WebPage/WebInspectorUI.cpp
WebProcess/WebPage/WebOpenPanelResultListener.cpp
-WebProcess/WebPage/WebPage.cpp
+WebProcess/WebPage/WebPage.cpp @no-unify
WebProcess/WebPage/WebPageGroupProxy.cpp
WebProcess/WebPage/WebPageOverlay.cpp
WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (235207 => 235208)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-08-22 22:49:42 UTC (rev 235207)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-08-22 22:51:22 UTC (rev 235208)
@@ -821,6 +821,7 @@
2DE6943E18BD2A68005C15E5 /* SmartMagnificationControllerMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DE6943C18BD2A68005C15E5 /* SmartMagnificationControllerMessages.h */; };
2DEAC5CF1AC368BB00A195D8 /* _WKFindOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DEAC5CE1AC368BB00A195D8 /* _WKFindOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
2DEB1D2E2127473600933906 /* ArgumentCodersCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AAF0C4912B16334008E49E2 /* ArgumentCodersCF.cpp */; };
+ 2DF6FE52212E110900469030 /* WebPage.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC963D6A113DD19200574BE2 /* WebPage.cpp */; };
2DF9593B18A42412009785A1 /* ViewGestureControllerIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DF9593418A42412009785A1 /* ViewGestureControllerIOS.mm */; };
2DF9EEE51A781FB400B6CFBE /* APIFrameInfo.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2DF9EEE31A781FB400B6CFBE /* APIFrameInfo.cpp */; };
2DF9EEE61A781FB400B6CFBE /* APIFrameInfo.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DF9EEE41A781FB400B6CFBE /* APIFrameInfo.h */; };
@@ -11435,6 +11436,7 @@
31A2EC4A148997C200810D71 /* WebNotificationManagerProxy.cpp in Sources */,
31A2EC4D148997C200810D71 /* WebNotificationProvider.cpp in Sources */,
BC857F7E12B82CEE00EDEB2E /* WebOpenPanelResultListenerProxy.cpp in Sources */,
+ 2DF6FE52212E110900469030 /* WebPage.cpp in Sources */,
8372DB281A67562800C697C5 /* WebPageDiagnosticLoggingClient.cpp in Sources */,
BC7B6207129A0A6700D174A4 /* WebPageGroup.cpp in Sources */,
2D9EA3111A96D9EB002D2807 /* WebPageInjectedBundleClient.cpp in Sources */,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
