Title: [235357] trunk/Source/WebCore
- Revision
- 235357
- Author
- yusukesuz...@slowstart.org
- Date
- 2018-08-27 01:52:40 -0700 (Mon, 27 Aug 2018)
Log Message
Shrink size of HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=188945
Reviewed by Darin Adler.
Shrink the size of HTMLCollection by reordering members.
No behavior change.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
* html/HTMLCollection.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235356 => 235357)
--- trunk/Source/WebCore/ChangeLog 2018-08-27 08:31:43 UTC (rev 235356)
+++ trunk/Source/WebCore/ChangeLog 2018-08-27 08:52:40 UTC (rev 235357)
@@ -1,5 +1,20 @@
2018-08-25 Yusuke Suzuki <yusukesuz...@slowstart.org>
+ Shrink size of HTMLCollection
+ https://bugs.webkit.org/show_bug.cgi?id=188945
+
+ Reviewed by Darin Adler.
+
+ Shrink the size of HTMLCollection by reordering members.
+
+ No behavior change.
+
+ * html/HTMLCollection.cpp:
+ (WebCore::HTMLCollection::HTMLCollection):
+ * html/HTMLCollection.h:
+
+2018-08-25 Yusuke Suzuki <yusukesuz...@slowstart.org>
+
Shrink size of XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=188944
Modified: trunk/Source/WebCore/html/HTMLCollection.cpp (235356 => 235357)
--- trunk/Source/WebCore/html/HTMLCollection.cpp 2018-08-27 08:31:43 UTC (rev 235356)
+++ trunk/Source/WebCore/html/HTMLCollection.cpp 2018-08-27 08:52:40 UTC (rev 235357)
@@ -108,10 +108,10 @@
}
HTMLCollection::HTMLCollection(ContainerNode& ownerNode, CollectionType type)
- : m_ownerNode(ownerNode)
- , m_collectionType(type)
+ : m_collectionType(type)
, m_invalidationType(invalidationTypeExcludingIdAndNameAttributes(type))
, m_rootType(rootTypeFromCollectionType(type))
+ , m_ownerNode(ownerNode)
{
ASSERT(m_rootType == static_cast<unsigned>(rootTypeFromCollectionType(type)));
ASSERT(m_invalidationType == static_cast<unsigned>(invalidationTypeExcludingIdAndNameAttributes(type)));
Modified: trunk/Source/WebCore/html/HTMLCollection.h (235356 => 235357)
--- trunk/Source/WebCore/html/HTMLCollection.h 2018-08-27 08:31:43 UTC (rev 235356)
+++ trunk/Source/WebCore/html/HTMLCollection.h 2018-08-27 08:52:40 UTC (rev 235357)
@@ -101,14 +101,15 @@
enum RootType { IsRootedAtNode, IsRootedAtDocument };
static RootType rootTypeFromCollectionType(CollectionType);
- Ref<ContainerNode> m_ownerNode;
+ mutable Lock m_namedElementCacheAssignmentLock;
- mutable std::unique_ptr<CollectionNamedElementCache> m_namedElementCache;
- mutable Lock m_namedElementCacheAssignmentLock;
-
const unsigned m_collectionType : 5;
const unsigned m_invalidationType : 4;
const unsigned m_rootType : 1;
+
+ Ref<ContainerNode> m_ownerNode;
+
+ mutable std::unique_ptr<CollectionNamedElementCache> m_namedElementCache;
};
inline ContainerNode& HTMLCollection::rootNode() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes