Title: [235565] trunk/Tools
- Revision
- 235565
- Author
- mmaxfi...@apple.com
- Date
- 2018-08-31 13:08:08 -0700 (Fri, 31 Aug 2018)
Log Message
[WHLSL] Remove useless code in NameResolver
https://bugs.webkit.org/show_bug.cgi?id=189176
Reviewed by Dean Jackson and Thomas Denney.
The check will always pass becase the standard library contains at least one function with the correct name.
* WebGPUShadingLanguageRI/NameResolver.js:
(NameResolver.prototype.visitDotExpression):
(NameResolver.prototype._handlePropertyAccess): Deleted.
(NameResolver.prototype.visitIndexExpression): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235564 => 235565)
--- trunk/Tools/ChangeLog 2018-08-31 20:00:22 UTC (rev 235564)
+++ trunk/Tools/ChangeLog 2018-08-31 20:08:08 UTC (rev 235565)
@@ -1,3 +1,17 @@
+2018-08-31 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ [WHLSL] Remove useless code in NameResolver
+ https://bugs.webkit.org/show_bug.cgi?id=189176
+
+ Reviewed by Dean Jackson and Thomas Denney.
+
+ The check will always pass becase the standard library contains at least one function with the correct name.
+
+ * WebGPUShadingLanguageRI/NameResolver.js:
+ (NameResolver.prototype.visitDotExpression):
+ (NameResolver.prototype._handlePropertyAccess): Deleted.
+ (NameResolver.prototype.visitIndexExpression): Deleted.
+
2018-08-31 Simon Fraser <simon.fra...@apple.com>
Make it possible to mark tests as leaks in TestExpectations
Modified: trunk/Tools/WebGPUShadingLanguageRI/NameResolver.js (235564 => 235565)
--- trunk/Tools/WebGPUShadingLanguageRI/NameResolver.js 2018-08-31 20:00:22 UTC (rev 235564)
+++ trunk/Tools/WebGPUShadingLanguageRI/NameResolver.js 2018-08-31 20:08:08 UTC (rev 235565)
@@ -166,16 +166,6 @@
super.visitReturn(node);
}
- _handlePropertyAccess(node)
- {
- node.possibleGetOverloads = this._nameContext.get(Func, node.getFuncName);
- node.possibleSetOverloads = this._nameContext.get(Func, node.setFuncName);
- node.possibleAndOverloads = this._nameContext.get(Func, node.andFuncName);
-
- if (!node.possibleGetOverloads && !node.possibleAndOverloads)
- throw new WTypeError(node.origin.originString, "Cannot find either " + node.getFuncName + " or " + node.andFuncName);
- }
-
visitDotExpression(node)
{
// This could be a reference to an enum. Let's resolve that now.
@@ -190,16 +180,9 @@
}
}
- this._handlePropertyAccess(node);
super.visitDotExpression(node);
}
- visitIndexExpression(node)
- {
- this._handlePropertyAccess(node);
- super.visitIndexExpression(node);
- }
-
visitCallExpression(node)
{
let funcs = this._nameContext.get(Func, node.name);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
