Title: [235621] trunk/Source/WebCore
- Revision
- 235621
- Author
- dba...@webkit.org
- Date
- 2018-09-04 11:20:04 -0700 (Tue, 04 Sep 2018)
Log Message
Attempt to fix failing tests following r235615 (https://bugs.webkit.org/show_bug.cgi?id=187925)
An inline text box that does not have combined text and contains a single character
should be considered as having text content.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::hasTextContent const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235620 => 235621)
--- trunk/Source/WebCore/ChangeLog 2018-09-04 18:10:52 UTC (rev 235620)
+++ trunk/Source/WebCore/ChangeLog 2018-09-04 18:20:04 UTC (rev 235621)
@@ -1,3 +1,13 @@
+2018-09-04 Daniel Bates <daba...@apple.com>
+
+ Attempt to fix failing tests following r235615 (https://bugs.webkit.org/show_bug.cgi?id=187925)
+
+ An inline text box that does not have combined text and contains a single character
+ should be considered as having text content.
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::hasTextContent const):
+
2018-09-04 Per Arne Vollan <pvol...@apple.com>
Add test for fix in https://bugs.webkit.org/show_bug.cgi?id=187922
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (235620 => 235621)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2018-09-04 18:10:52 UTC (rev 235620)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2018-09-04 18:20:04 UTC (rev 235621)
@@ -84,7 +84,7 @@
ASSERT(m_len == 1);
return !combinedText->combinedStringForRendering().isEmpty();
}
- return false;
+ return m_len;
}
void InlineTextBox::markDirty(bool dirty)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
