Title: [235931] trunk/Tools
- Revision
- 235931
- Author
- [email protected]
- Date
- 2018-09-11 23:08:29 -0700 (Tue, 11 Sep 2018)
Log Message
FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=189382
Reviewed by Ryosuke Niwa.
Fix the test by specifying colors in RGB colorspace.
* TestWebKitAPI/Tests/mac/FontManagerTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235930 => 235931)
--- trunk/Tools/ChangeLog 2018-09-12 05:05:10 UTC (rev 235930)
+++ trunk/Tools/ChangeLog 2018-09-12 06:08:29 UTC (rev 235931)
@@ -1,3 +1,15 @@
+2018-09-11 Wenson Hsieh <[email protected]>
+
+ FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
+ https://bugs.webkit.org/show_bug.cgi?id=189382
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix the test by specifying colors in RGB colorspace.
+
+ * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
+ (TestWebKitAPI::TEST):
+
2018-09-11 Fujii Hironori <[email protected]>
[Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm (235930 => 235931)
--- trunk/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm 2018-09-12 05:05:10 UTC (rev 235930)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm 2018-09-12 06:08:29 UTC (rev 235931)
@@ -270,7 +270,7 @@
};
// 1. Select "foo" and turn it red; verify that the font element is used for fully opaque colors.
- colorPanel.color = NSColor.redColor;
+ colorPanel.color = [NSColor colorWithRed:1 green:0 blue:0 alpha:1];
[webView selectWord:nil];
[webView changeColor:colorPanel];
checkFontColorAtStartAndEndWithInputEvents("rgb(255, 0, 0)");
@@ -296,7 +296,7 @@
EXPECT_FALSE([[webView objectByEvaluatingJavaScript:@"!!bar.querySelector('font')"] boolValue]);
// 4a. Now collapse the selection to the end and set the typing style color to green.
- colorPanel.color = NSColor.greenColor;
+ colorPanel.color = [NSColor colorWithRed:0 green:1 blue:0 alpha:1];
[webView collapseToEnd];
[webView changeColor:colorPanel];
EXPECT_WK_STREQ("formatFontColor", [webView stringByEvaluatingJavaScript:@"lastInputEvent.inputType"]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
