Title: [236010] trunk/Source
Revision
236010
Author
jer.no...@apple.com
Date
2018-09-14 10:03:35 -0700 (Fri, 14 Sep 2018)

Log Message

Turn SourceBufferChangeTypeEnabled on by default
https://bugs.webkit.org/show_bug.cgi?id=189527

Reviewed by Eric Carlson.

Source/WebCore:

* page/Settings.yaml:

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (236009 => 236010)


--- trunk/Source/WebCore/ChangeLog	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebCore/ChangeLog	2018-09-14 17:03:35 UTC (rev 236010)
@@ -1,3 +1,12 @@
+2018-09-14  Jer Noble  <jer.no...@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * page/Settings.yaml:
+
 2018-09-14  Devin Rousso  <web...@devinrousso.com>
 
         Web Inspector: Record actions performed on ImageBitmapRenderingContext

Modified: trunk/Source/WebCore/page/Settings.yaml (236009 => 236010)


--- trunk/Source/WebCore/page/Settings.yaml	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebCore/page/Settings.yaml	2018-09-14 17:03:35 UTC (rev 236010)
@@ -431,7 +431,7 @@
   conditional: MEDIA_SOURCE
 
 sourceBufferChangeTypeEnabled:
-  initial: false
+  initial: true
   conditional: MEDIA_SOURCE
 
 # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.

Modified: trunk/Source/WebKit/ChangeLog (236009 => 236010)


--- trunk/Source/WebKit/ChangeLog	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebKit/ChangeLog	2018-09-14 17:03:35 UTC (rev 236010)
@@ -1,3 +1,13 @@
+2018-09-14  Jer Noble  <jer.no...@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * Shared/WebPreferences.yaml:
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
 2018-09-14  Michael Catanzaro  <mcatanz...@igalia.com>
 
         Unreviewed, speculative WPE build fix after r236004

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (236009 => 236010)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-09-14 17:03:35 UTC (rev 236010)
@@ -1125,6 +1125,11 @@
   defaultValue: true
   webcoreBinding: RuntimeEnabledFeatures
 
+SourceBufferChangeTypeEnabled:
+  type: bool
+  defaultValue: true
+  condition: ENABLE(MEDIA_SOURCE)
+
 # For experimental features:
 # The type should be boolean.
 # You must provide a humanReadableName and humanReadableDescription for all experimental features. They
@@ -1270,14 +1275,6 @@
   category: internal
   webcoreBinding: none
 
-SourceBufferChangeTypeEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Media Source Codec Switching Support"
-  humanReadableDescription: "Media Source Codec Switching through changeType()"
-  category: internal
-  condition: ENABLE(MEDIA_SOURCE)
-
 ResourceLoadStatisticsDebugMode:
   type: bool
   defaultValue: false

Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (236009 => 236010)


--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h	2018-09-14 17:03:35 UTC (rev 236010)
@@ -380,7 +380,7 @@
 WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
 
-// Defaults to false;
+// Defaults to true;
 WK_EXPORT void WKPreferencesSetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef);
 

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (236009 => 236010)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-09-14 17:03:35 UTC (rev 236010)
@@ -1,3 +1,13 @@
+2018-09-14  Jer Noble  <jer.no...@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+
 2018-09-12  Alex Christensen  <achristen...@webkit.org>
 
         Fix an internal build after r235935

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (236009 => 236010)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2018-09-14 16:50:14 UTC (rev 236009)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2018-09-14 17:03:35 UTC (rev 236010)
@@ -605,7 +605,7 @@
         [NSNumber numberWithBool:NO], WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
 #if ENABLE(MEDIA_SOURCE)
         [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
-        @NO, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
+        @YES, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
 #endif
 #if ENABLE(SERVICE_CONTROLS)
         [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to