Title: [236043] releases/WebKitGTK/webkit-2.22/Source/_javascript_Core
Revision
236043
Author
carlo...@webkit.org
Date
2018-09-17 01:50:43 -0700 (Mon, 17 Sep 2018)

Log Message

Merge r235238 - YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag
https://bugs.webkit.org/show_bug.cgi?id=188895

Reviewed by Mark Lam.

Found while working on another change.  This will allow processing of nested
parenthesis that require saved ParenContext structures.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog (236042 => 236043)


--- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog	2018-09-17 08:50:38 UTC (rev 236042)
+++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog	2018-09-17 08:50:43 UTC (rev 236043)
@@ -1,3 +1,16 @@
+2018-08-23  Michael Saboff  <msab...@apple.com>
+
+        YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag
+        https://bugs.webkit.org/show_bug.cgi?id=188895
+
+        Reviewed by Mark Lam.
+
+        Found while working on another change.  This will allow processing of nested
+        parenthesis that require saved ParenContext structures.
+
+        * yarr/YarrJIT.cpp:
+        (JSC::Yarr::YarrGenerator::compile):
+
 2018-08-22  Mark Lam  <mark....@apple.com>
 
         The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.

Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/yarr/YarrJIT.cpp (236042 => 236043)


--- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/yarr/YarrJIT.cpp	2018-09-17 08:50:38 UTC (rev 236042)
+++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/yarr/YarrJIT.cpp	2018-09-17 08:50:43 UTC (rev 236043)
@@ -3545,11 +3545,6 @@
         }
 #endif
 
-#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS)
-        if (m_containsNestedSubpatterns)
-            codeBlock.setUsesPaternContextBuffer();
-#endif
-
         // We need to compile before generating code since we set flags based on compilation that
         // are used during generation.
         opCompileBody(m_pattern.m_body);
@@ -3565,6 +3560,11 @@
         if (m_disassembler)
             m_disassembler->setStartOfCode(label());
 
+#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS)
+        if (m_containsNestedSubpatterns)
+            codeBlock.setUsesPaternContextBuffer();
+#endif
+
         generateEnter();
 
         Jump hasInput = checkInput();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to