Title: [236522] trunk/Source/WebCore
Revision
236522
Author
rn...@webkit.org
Date
2018-09-26 13:33:00 -0700 (Wed, 26 Sep 2018)

Log Message

Selection should work across shadow boundary when initiated by a mouse drag
https://bugs.webkit.org/show_bug.cgi?id=151380
<rdar://problem/24363872>

Revert the change that I said I would from r236519.

* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (236521 => 236522)


--- trunk/Source/WebCore/ChangeLog	2018-09-26 20:31:29 UTC (rev 236521)
+++ trunk/Source/WebCore/ChangeLog	2018-09-26 20:33:00 UTC (rev 236522)
@@ -1,3 +1,14 @@
+2018-09-26  Ryosuke Niwa  <rn...@webkit.org>
+
+        Selection should work across shadow boundary when initiated by a mouse drag
+        https://bugs.webkit.org/show_bug.cgi?id=151380
+        <rdar://problem/24363872>
+
+        Revert the change that I said I would from r236519.
+
+        * editing/VisibleSelection.cpp:
+        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
+
 2018-09-26  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r236511.

Modified: trunk/Source/WebCore/editing/VisibleSelection.cpp (236521 => 236522)


--- trunk/Source/WebCore/editing/VisibleSelection.cpp	2018-09-26 20:31:29 UTC (rev 236521)
+++ trunk/Source/WebCore/editing/VisibleSelection.cpp	2018-09-26 20:33:00 UTC (rev 236522)
@@ -538,10 +538,10 @@
     }
 
     if (m_baseIsFirst) {
-        m_extent = adjustPositionForEnd(m_end, startNode.ptr());
+        m_extent = adjustPositionForEnd(m_end, m_start.containerNode());
         m_end = m_extent;
     } else {
-        m_extent = adjustPositionForStart(m_start, endNode.ptr());
+        m_extent = adjustPositionForStart(m_start, m_end.containerNode());
         m_start = m_extent;
     }
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to