Title: [236967] trunk/Source/WebCore
- Revision
- 236967
- Author
- ab...@igalia.com
- Date
- 2018-10-09 10:40:01 -0700 (Tue, 09 Oct 2018)
Log Message
[MSE][GStreamer] r236735 has some dead ASSERTs that need to be moved
https://bugs.webkit.org/show_bug.cgi?id=190394
Reviewed by Xabier Rodriguez-Calvar.
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::createOptionalParserForFormat):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (236966 => 236967)
--- trunk/Source/WebCore/ChangeLog 2018-10-09 17:18:58 UTC (rev 236966)
+++ trunk/Source/WebCore/ChangeLog 2018-10-09 17:40:01 UTC (rev 236967)
@@ -1,3 +1,13 @@
+2018-10-09 Alicia Boya García <ab...@igalia.com>
+
+ [MSE][GStreamer] r236735 has some dead ASSERTs that need to be moved
+ https://bugs.webkit.org/show_bug.cgi?id=190394
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+ (WebCore::createOptionalParserForFormat):
+
2018-10-09 Chris Dumez <cdu...@apple.com>
Have DOMWindow get its frame from its document
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (236966 => 236967)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2018-10-09 17:18:58 UTC (rev 236966)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2018-10-09 17:40:01 UTC (rev 236967)
@@ -859,20 +859,20 @@
if (!g_strcmp0(mediaType, "audio/x-opus")) {
GstElement* opusparse = gst_element_factory_make("opusparse", parserName.get());
+ ASSERT(opusparse);
g_return_val_if_fail(opusparse, nullptr);
- ASSERT(opusparse);
return GRefPtr<GstElement>(opusparse);
}
if (!g_strcmp0(mediaType, "audio/x-vorbis")) {
GstElement* vorbisparse = gst_element_factory_make("vorbisparse", parserName.get());
+ ASSERT(vorbisparse);
g_return_val_if_fail(vorbisparse, nullptr);
- ASSERT(vorbisparse);
return GRefPtr<GstElement>(vorbisparse);
}
if (!g_strcmp0(mediaType, "video/x-h264")) {
GstElement* h264parse = gst_element_factory_make("h264parse", parserName.get());
+ ASSERT(h264parse);
g_return_val_if_fail(h264parse, nullptr);
- ASSERT(h264parse);
return GRefPtr<GstElement>(h264parse);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
