Title: [236994] trunk/Source/WebKit
- Revision
- 236994
- Author
- you...@apple.com
- Date
- 2018-10-09 17:31:33 -0700 (Tue, 09 Oct 2018)
Log Message
ASSERTION FAILED: m_cachesLocks.contains(sessionID) in WebKit::CacheStorageEngineConnection::dereference(PAL::SessionID, unsigned long long)
https://bugs.webkit.org/show_bug.cgi?id=190373
<rdar://problem/45106402>
Reviewed by Alex Christensen.
This assertion can be hit if:
- WebProcess has a DOMCache
- NetworkProcess crashes
- WebProcess navigates and dereference DOMCache.
Remove this assertion as it is hit when a test is using testRunner.terminateNetworkProcess().
* NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::dereference):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236993 => 236994)
--- trunk/Source/WebKit/ChangeLog 2018-10-10 00:28:14 UTC (rev 236993)
+++ trunk/Source/WebKit/ChangeLog 2018-10-10 00:31:33 UTC (rev 236994)
@@ -1,3 +1,20 @@
+2018-10-09 Youenn Fablet <you...@apple.com>
+
+ ASSERTION FAILED: m_cachesLocks.contains(sessionID) in WebKit::CacheStorageEngineConnection::dereference(PAL::SessionID, unsigned long long)
+ https://bugs.webkit.org/show_bug.cgi?id=190373
+ <rdar://problem/45106402>
+
+ Reviewed by Alex Christensen.
+
+ This assertion can be hit if:
+ - WebProcess has a DOMCache
+ - NetworkProcess crashes
+ - WebProcess navigates and dereference DOMCache.
+ Remove this assertion as it is hit when a test is using testRunner.terminateNetworkProcess().
+
+ * NetworkProcess/cache/CacheStorageEngineConnection.cpp:
+ (WebKit::CacheStorageEngineConnection::dereference):
+
2018-10-09 Jer Noble <jer.no...@apple.com>
Crash when closing WKWebView during enter fullscreen animation
Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp (236993 => 236994)
--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp 2018-10-10 00:28:14 UTC (rev 236993)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp 2018-10-10 00:31:33 UTC (rev 236994)
@@ -132,7 +132,6 @@
void CacheStorageEngineConnection::dereference(PAL::SessionID sessionID, uint64_t cacheIdentifier)
{
RELEASE_LOG_IF_ALLOWED("dereference cache %" PRIu64, cacheIdentifier);
- ASSERT(m_cachesLocks.contains(sessionID));
auto& references = m_cachesLocks.ensure(sessionID, []() {
return HashMap<CacheIdentifier, LockCount> { };
}).iterator->value;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
