Title: [237002] trunk
- Revision
- 237002
- Author
- cdu...@apple.com
- Date
- 2018-10-10 09:30:07 -0700 (Wed, 10 Oct 2018)
Log Message
Unreviewed, rolling out r236802.
Working on getting the HTML spec updated instead
(https://github.com/whatwg/html/pull/4079)
Reverted changeset:
"Passing noopener=NOOPENER to window.open() should cause the
new window to not have an opener"
https://bugs.webkit.org/show_bug.cgi?id=190251
https://trac.webkit.org/changeset/236802
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (237001 => 237002)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-10 13:33:03 UTC (rev 237001)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-10 16:30:07 UTC (rev 237002)
@@ -1,3 +1,17 @@
+2018-10-10 Chris Dumez <cdu...@apple.com>
+
+ Unreviewed, rolling out r236802.
+
+ Working on getting the HTML spec updated instead
+ (https://github.com/whatwg/html/pull/4079)
+
+ Reverted changeset:
+
+ "Passing noopener=NOOPENER to window.open() should cause the
+ new window to not have an opener"
+ https://bugs.webkit.org/show_bug.cgi?id=190251
+ https://trac.webkit.org/changeset/236802
+
2018-10-09 Antoine Quint <grao...@apple.com>
Remove the frames() timing function
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt (237001 => 237002)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt 2018-10-10 13:33:03 UTC (rev 237001)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt 2018-10-10 16:30:07 UTC (rev 237002)
@@ -1,9 +1,10 @@
PASS tokenization should skip window features separators before `name`
-PASS feature `name` should be converted to ASCII lowercase
+FAIL feature `name` should be converted to ASCII lowercase assert_equals: "noopener=NOOPENER" should activate feature "noopener" expected null but got object "[object Window]"
PASS after `name`, tokenization should skip window features separators that are not "=" or ","
-PASS Tokenizing should ignore window feature separators except "," after initial "=" and before value
-PASS Tokenizing should read characters until first window feature separator as `value`
-PASS "noopener" should be based on name (key), not value
+FAIL Tokenizing should ignore window feature separators except "," after initial "=" and before value assert_equals: "noopener
+=\r noopener," should activate feature "noopener" expected null but got object "[object Window]"
+FAIL Tokenizing should read characters until first window feature separator as `value` assert_equals: "noopener=noopener" should set "noopener" expected null but got object "[object Window]"
+FAIL "noopener" should be based on name (key), not value assert_equals: "noopener=false" should activate feature "noopener" expected null but got object "[object Window]"
PASS invalid feature names should not tokenize as "noopener"
Modified: trunk/Source/WebCore/ChangeLog (237001 => 237002)
--- trunk/Source/WebCore/ChangeLog 2018-10-10 13:33:03 UTC (rev 237001)
+++ trunk/Source/WebCore/ChangeLog 2018-10-10 16:30:07 UTC (rev 237002)
@@ -1,3 +1,17 @@
+2018-10-10 Chris Dumez <cdu...@apple.com>
+
+ Unreviewed, rolling out r236802.
+
+ Working on getting the HTML spec updated instead
+ (https://github.com/whatwg/html/pull/4079)
+
+ Reverted changeset:
+
+ "Passing noopener=NOOPENER to window.open() should cause the
+ new window to not have an opener"
+ https://bugs.webkit.org/show_bug.cgi?id=190251
+ https://trac.webkit.org/changeset/236802
+
2018-10-10 Yusuke Suzuki <yusukesuz...@slowstart.org>
XMLHttpRequest should use reportExtraMemoryAllocated/reportExtraMemoryVisited instead of deprecatedReportExtraMemory
Modified: trunk/Source/WebCore/page/WindowFeatures.cpp (237001 => 237002)
--- trunk/Source/WebCore/page/WindowFeatures.cpp 2018-10-10 13:33:03 UTC (rev 237001)
+++ trunk/Source/WebCore/page/WindowFeatures.cpp 2018-10-10 16:30:07 UTC (rev 237002)
@@ -158,7 +158,7 @@
else if (equalLettersIgnoringASCIICase(key, "scrollbars"))
features.scrollbarsVisible = numericValue;
else if (equalLettersIgnoringASCIICase(key, "noopener"))
- features.noopener = true;
+ features.noopener = numericValue;
else if (numericValue == 1)
features.additionalFeatures.append(key.toString());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
