Title: [237126] trunk/Source/WebCore
- Revision
- 237126
- Author
- ctur...@igalia.com
- Date
- 2018-10-15 10:33:21 -0700 (Mon, 15 Oct 2018)
Log Message
Fix build error with !LOG_DISABLED in Release mode
https://bugs.webkit.org/show_bug.cgi?id=190465
Reviewed by Michael Catanzaro.
No tests due to no new functionality.
* workers/service/ServiceWorkerRegistrationKey.cpp:
* workers/service/ServiceWorkerRegistrationKey.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (237125 => 237126)
--- trunk/Source/WebCore/ChangeLog 2018-10-15 17:27:02 UTC (rev 237125)
+++ trunk/Source/WebCore/ChangeLog 2018-10-15 17:33:21 UTC (rev 237126)
@@ -1,3 +1,15 @@
+2018-10-15 Charlie Turner <ctur...@igalia.com>
+
+ Fix build error with !LOG_DISABLED in Release mode
+ https://bugs.webkit.org/show_bug.cgi?id=190465
+
+ Reviewed by Michael Catanzaro.
+
+ No tests due to no new functionality.
+
+ * workers/service/ServiceWorkerRegistrationKey.cpp:
+ * workers/service/ServiceWorkerRegistrationKey.h:
+
2018-10-15 Simon Fraser <simon.fra...@apple.com>
LayerListMutationDetector should take a reference
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp (237125 => 237126)
--- trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp 2018-10-15 17:27:02 UTC (rev 237125)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp 2018-10-15 17:33:21 UTC (rev 237126)
@@ -130,7 +130,7 @@
return ServiceWorkerRegistrationKey { { key.substring(0, first), key.substring(first + 1, second - first - 1), shortPort }, WTFMove(scope) };
}
-#ifndef NDEBUG
+#if !LOG_DISABLED
String ServiceWorkerRegistrationKey::loggingString() const
{
return makeString(m_topOrigin.debugString(), "-", m_scope.string());
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h (237125 => 237126)
--- trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h 2018-10-15 17:27:02 UTC (rev 237125)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h 2018-10-15 17:33:21 UTC (rev 237126)
@@ -59,7 +59,7 @@
String toDatabaseKey() const;
static std::optional<ServiceWorkerRegistrationKey> fromDatabaseKey(const String&);
-#ifndef NDEBUG
+#if !LOG_DISABLED
String loggingString() const;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes