Title: [237273] trunk
- Revision
- 237273
- Author
- jer.no...@apple.com
- Date
- 2018-10-18 16:01:42 -0700 (Thu, 18 Oct 2018)
Log Message
Enable WKPreferences._lowPowerVideoAudioBufferSizeEnabled by default
https://bugs.webkit.org/show_bug.cgi?id=190315
Source/WebKit:
Reviewed by Eric Carlson.
This preference is disabled for WebKitLegacy because it can interact poorly with clients' own use of audio.
It can be enabled for WebKit since it will only affect the WebProcess and not the client process.
* Shared/WebPreferences.yaml:
LayoutTests:
<rdar://problem/45047807>
Reviewed by Eric Carlson.
* media/audio-controls-timeline-in-media-document-expected.txt:
* media/audio-controls-timeline-in-media-document.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (237272 => 237273)
--- trunk/LayoutTests/ChangeLog 2018-10-18 22:52:15 UTC (rev 237272)
+++ trunk/LayoutTests/ChangeLog 2018-10-18 23:01:42 UTC (rev 237273)
@@ -1,5 +1,16 @@
2018-10-18 Jer Noble <jer.no...@apple.com>
+ Enable WKPreferences._lowPowerVideoAudioBufferSizeEnabled by default
+ https://bugs.webkit.org/show_bug.cgi?id=190315
+ <rdar://problem/45047807>
+
+ Reviewed by Eric Carlson.
+
+ * media/audio-controls-timeline-in-media-document-expected.txt:
+ * media/audio-controls-timeline-in-media-document.html:
+
+2018-10-18 Jer Noble <jer.no...@apple.com>
+
Safari is not able to adapt between H264 streams with EditList and without EditList
https://bugs.webkit.org/show_bug.cgi?id=190638
<rdar://problem/45342208>
Modified: trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt (237272 => 237273)
--- trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt 2018-10-18 22:52:15 UTC (rev 237272)
+++ trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt 2018-10-18 23:01:42 UTC (rev 237273)
@@ -1,6 +1,6 @@
Pass if the timeline of audio in a media document is properly updated during playback.
EVENT(timeupdate)
-TEST(timeLineValue() > 0) OK
+EXPECTED (timeLineValue() > '0') OK
END OF TEST
Modified: trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html (237272 => 237273)
--- trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html 2018-10-18 22:52:15 UTC (rev 237272)
+++ trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html 2018-10-18 23:01:42 UTC (rev 237273)
@@ -13,13 +13,12 @@
return timeline.value;
}
-function iframeLoaded()
+async function iframeLoaded()
{
video = iframe.contentDocument.querySelector("video");
- video.addEventListener("timeupdate", function() {
- consoleWrite("EVENT(timeupdate)");
- testAndEnd("timeLineValue() > 0");
- });
+ await waitFor(video, 'timeupdate');
+ await testExpectedEventually("timeLineValue()", 0, ">");
+ endTest();
}
var video;
Modified: trunk/Source/WebKit/ChangeLog (237272 => 237273)
--- trunk/Source/WebKit/ChangeLog 2018-10-18 22:52:15 UTC (rev 237272)
+++ trunk/Source/WebKit/ChangeLog 2018-10-18 23:01:42 UTC (rev 237273)
@@ -1,3 +1,15 @@
+2018-10-18 Jer Noble <jer.no...@apple.com>
+
+ Enable WKPreferences._lowPowerVideoAudioBufferSizeEnabled by default
+ https://bugs.webkit.org/show_bug.cgi?id=190315
+
+ Reviewed by Eric Carlson.
+
+ This preference is disabled for WebKitLegacy because it can interact poorly with clients' own use of audio.
+ It can be enabled for WebKit since it will only affect the WebProcess and not the client process.
+
+ * Shared/WebPreferences.yaml:
+
2018-10-18 Eric Carlson <eric.carl...@apple.com>
[MediaStream] Allow ports to optionally do screen capture in the UI process
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (237272 => 237273)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-10-18 22:52:15 UTC (rev 237272)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-10-18 23:01:42 UTC (rev 237273)
@@ -452,7 +452,7 @@
LowPowerVideoAudioBufferSizeEnabled:
type: bool
- defaultValue: false
+ defaultValue: true
webcoreBinding: DeprecatedGlobalSettings
ThreadedScrollingEnabled:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
