Title: [237678] trunk/Tools
- Revision
- 237678
- Author
- csaave...@igalia.com
- Date
- 2018-11-01 06:35:36 -0700 (Thu, 01 Nov 2018)
Log Message
[WPE] Add missing libsoup patch to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=191149
Reviewed by Žan Doberšek.
* wpe/jhbuild.modules:
* wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/Tools/ChangeLog (237677 => 237678)
--- trunk/Tools/ChangeLog 2018-11-01 11:27:11 UTC (rev 237677)
+++ trunk/Tools/ChangeLog 2018-11-01 13:35:36 UTC (rev 237678)
@@ -1,5 +1,15 @@
2018-11-01 Claudio Saavedra <csaave...@igalia.com>
+ [WPE] Add missing libsoup patch to jhbuild
+ https://bugs.webkit.org/show_bug.cgi?id=191149
+
+ Reviewed by Žan Doberšek.
+
+ * wpe/jhbuild.modules:
+ * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
+
+2018-11-01 Claudio Saavedra <csaave...@igalia.com>
+
Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
Modified: trunk/Tools/wpe/jhbuild.modules (237677 => 237678)
--- trunk/Tools/wpe/jhbuild.modules 2018-11-01 11:27:11 UTC (rev 237677)
+++ trunk/Tools/wpe/jhbuild.modules 2018-11-01 13:35:36 UTC (rev 237678)
@@ -100,6 +100,7 @@
<branch module="/pub/GNOME/sources/libsoup/2.60/libsoup-2.60.3.tar.xz" version="2.60.3"
repo="ftp.gnome.org"
hash="sha256:1b0dc762f23abe4e0d29b77370e539fd35f31d8e8e0318d6ddccff395be68a22"/>
+ <patch file="libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch" strip="1"/>
</autotools>
<autotools id="fonts" supports-non-srcdir-builds="no"
Added: trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch (0 => 237678)
--- trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch (rev 0)
+++ trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch 2018-11-01 13:35:36 UTC (rev 237678)
@@ -0,0 +1,29 @@
+From e8995d4e1d5cf984cf10327c59808976425b2f9c Mon Sep 17 00:00:00 2001
+From: Carlos Garcia Campos <cgar...@igalia.com>
+Date: Fri, 20 Apr 2018 12:14:55 +0200
+Subject: [PATCH] soup-socket: fix critical warning when the peer-certificate
+ changes after disconnect
+
+(process:15586): GLib-GIO-CRITICAL **: 12:14:39.627: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed
+
+We should disconnect the signal on disconnect_internal before clearing
+the connection object.
+---
+ libsoup/soup-socket.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsoup/soup-socket.c b/libsoup/soup-socket.c
+index 5363dc72..311c627c 100644
+--- a/libsoup/soup-socket.c
++++ b/libsoup/soup-socket.c
+@@ -188,6 +188,7 @@ disconnect_internal (SoupSocket *sock, gboolean close)
+ g_clear_object (&priv->gsock);
+ if (priv->conn && close) {
+ g_io_stream_close (priv->conn, NULL, NULL);
++ g_signal_handlers_disconnect_by_data (priv->conn, sock);
+ g_clear_object (&priv->conn);
+ }
+
+--
+2.19.1
+
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
