Title: [237682] trunk/Source/WebKit
- Revision
- 237682
- Author
- csaave...@igalia.com
- Date
- 2018-11-01 09:40:15 -0700 (Thu, 01 Nov 2018)
Log Message
ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
https://bugs.webkit.org/show_bug.cgi?id=191152
Reviewed by Chris Dumez.
The statistics file is not created unconditionally, so
make sure it exists before logging an error.
* UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
Check that the file exists before logging an error.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (237681 => 237682)
--- trunk/Source/WebKit/ChangeLog 2018-11-01 16:11:28 UTC (rev 237681)
+++ trunk/Source/WebKit/ChangeLog 2018-11-01 16:40:15 UTC (rev 237682)
@@ -1,5 +1,19 @@
2018-11-01 Claudio Saavedra <csaave...@igalia.com>
+ ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
+ https://bugs.webkit.org/show_bug.cgi?id=191152
+
+ Reviewed by Chris Dumez.
+
+ The statistics file is not created unconditionally, so
+ make sure it exists before logging an error.
+
+ * UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:
+ (WebKit::ResourceLoadStatisticsPersistentStorage::clear):
+ Check that the file exists before logging an error.
+
+2018-11-01 Claudio Saavedra <csaave...@igalia.com>
+
[GLIB] Silent a build warning when not using Wayland
Unreviewed.
Modified: trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp (237681 => 237682)
--- trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp 2018-11-01 16:11:28 UTC (rev 237681)
+++ trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp 2018-11-01 16:40:15 UTC (rev 237682)
@@ -307,7 +307,7 @@
stopMonitoringDisk();
- if (!FileSystem::deleteFile(filePath))
+ if (!FileSystem::deleteFile(filePath) && FileSystem::fileExists(filePath))
RELEASE_LOG_ERROR(ResourceLoadStatistics, "ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file: %s", filePath.utf8().data());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
