Title: [237688] trunk
- Revision
- 237688
- Author
- you...@apple.com
- Date
- 2018-11-01 11:18:14 -0700 (Thu, 01 Nov 2018)
Log Message
RTCTrackEvent.streams should be SameObject
https://bugs.webkit.org/show_bug.cgi?id=191130
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
* web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt:
Source/WebCore:
Mimick SameObject using CachedAttribute.
Covered by rebased test.
* Modules/mediastream/RTCTrackEvent.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (237687 => 237688)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-01 18:02:56 UTC (rev 237687)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-01 18:18:14 UTC (rev 237688)
@@ -1,3 +1,12 @@
+2018-11-01 Youenn Fablet <you...@apple.com>
+
+ RTCTrackEvent.streams should be SameObject
+ https://bugs.webkit.org/show_bug.cgi?id=191130
+
+ Reviewed by Eric Carlson.
+
+ * web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt:
+
2018-10-31 Chris Dumez <cdu...@apple.com>
Resync XHR Web Platform Tests from upstream 44dd29fb0d
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt (237687 => 237688)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt 2018-11-01 18:02:56 UTC (rev 237687)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt 2018-11-01 18:18:14 UTC (rev 237688)
@@ -1,5 +1,5 @@
-FAIL new RTCTrackEvent() with valid receiver, track, transceiver should succeed assert_equals: expected [] but got []
+PASS new RTCTrackEvent() with valid receiver, track, transceiver should succeed
PASS new RTCTrackEvent() with valid receiver, track, streams, transceiver should succeed
PASS new RTCTrackEvent() with valid receiver, track, multiple streams, transceiver should succeed
PASS new RTCTrackEvent() with unrelated receiver, track, streams, transceiver should succeed
Modified: trunk/Source/WebCore/ChangeLog (237687 => 237688)
--- trunk/Source/WebCore/ChangeLog 2018-11-01 18:02:56 UTC (rev 237687)
+++ trunk/Source/WebCore/ChangeLog 2018-11-01 18:18:14 UTC (rev 237688)
@@ -1,3 +1,15 @@
+2018-11-01 Youenn Fablet <you...@apple.com>
+
+ RTCTrackEvent.streams should be SameObject
+ https://bugs.webkit.org/show_bug.cgi?id=191130
+
+ Reviewed by Eric Carlson.
+
+ Mimick SameObject using CachedAttribute.
+ Covered by rebased test.
+
+ * Modules/mediastream/RTCTrackEvent.idl:
+
2018-10-31 Zalan Bujtas <za...@apple.com>
[LFC][IFC] Add support for inline-block elements.
Modified: trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl (237687 => 237688)
--- trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl 2018-11-01 18:02:56 UTC (rev 237687)
+++ trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl 2018-11-01 18:18:14 UTC (rev 237688)
@@ -35,7 +35,7 @@
] interface RTCTrackEvent : Event {
readonly attribute RTCRtpReceiver receiver;
readonly attribute MediaStreamTrack track;
- readonly attribute FrozenArray<MediaStream> streams;
+ [CachedAttribute, SameObject] readonly attribute FrozenArray<MediaStream> streams;
readonly attribute RTCRtpTransceiver transceiver;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
